[WEB-1964]chore: added current cycle to cycle dropdown

[vamsikrishnamathala]

Description

Added currentCycleId to the Cycle dropdown to exclude the current cycle from the dropdown.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

References

WEB-1964

Summary by CodeRabbit

• New Features
  • Enhanced cycle dropdown functionality by introducing an optional currentCycleId property.
  • Improved cycle selection management with more flexible filtering logic to exclude the currently selected cycle.

[coderabbitai]

Walkthrough

This pull request introduces an optional currentCycleId property to two related components in the cycle dropdown system. The changes modify the CycleOptionsProps and Props types in cycle-options.tsx and index.tsx respectively, allowing the components to receive and handle the ID of the currently selected cycle. The modification enhances the component's ability to manage cycle selection state by excluding the current cycle from the displayed options.

Changes

File	Change Summary
web/core/components/dropdowns/cycle/cycle-options.tsx	Added optional currentCycleId?: string to CycleOptionsProps type; Updated cycleIds computation to exclude currentCycleId from the list.
web/core/components/dropdowns/cycle/index.tsx	Added optional currentCycleId?: string to Props type; Passed currentCycleId to CycleOptions component when dropdown is open.

Suggested labels

🌟enhancement

Suggested reviewers

• SatishGandham
• rahulramesha

Poem

🐰 A cycle's tale, now more precise,
With currentCycleId rolling the dice,
Dropdown magic, selection's delight,
Filtering cycles with newfound might,
Code hops forward, rabbit's surprise! 🌈

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f94fb04 and bb76f7b.

📒 Files selected for processing (2)

• web/core/components/dropdowns/cycle/cycle-options.tsx (2 hunks)
• web/core/components/dropdowns/cycle/index.tsx (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• web/core/components/dropdowns/cycle/cycle-options.tsx
• web/core/components/dropdowns/cycle/index.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

web/core/components/dropdowns/cycle/index.tsx (1)

29-29: Add JSDoc documentation for the new prop.

Consider adding documentation to explain the purpose and usage of currentCycleId.

+  /** ID of the current cycle to be excluded from the dropdown options */
   currentCycleId?: string;

web/core/components/dropdowns/cycle/cycle-options.tsx (1)

34-34: Add JSDoc documentation for the new prop.

Consider adding documentation to explain the purpose and usage of currentCycleId.

+  /** ID of the current cycle to be excluded from the dropdown options */
   currentCycleId?: string;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58ac1dc and bef6acf.

📒 Files selected for processing (2)

• web/core/components/dropdowns/cycle/cycle-options.tsx (2 hunks)
• web/core/components/dropdowns/cycle/index.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (1)

web/core/components/dropdowns/cycle/cycle-options.tsx (1)

71-73: Verify implementation against PR objective.

The PR objective states that currentCycleId should be used to exclude the current cycle from dropdown options. However, the current implementation does the opposite by explicitly including it. Please clarify if this is intentional or if the implementation should be modified to match the PR objective.

🧰 Tools

🪛 Biome (1.9.4)

[error] 73-73: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)