chore: add select all/deselect all functionality when adding existing work item #7045
Conversation
|
""" WalkthroughBulk selection functionality was introduced to the existing issues list modal. A new handler toggles between selecting and deselecting all filtered issues, and a button reflecting this state was added to the modal footer with left alignment. Additionally, translation files for multiple languages were updated to include localized strings for "Select All" and "Deselect All". Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Modal as ExistingIssuesListModal
participant State as IssueSelectionState
User->>Modal: Clicks "Select All"/"Deselect All" button
Modal->>State: handleSelectIssues()
alt All filtered issues selected
State->>State: Clear selection of all filtered issues
Modal->>User: Update button label to "Select All"
else Not all filtered issues selected
State->>State: Select all filtered issues
Modal->>User: Update button label to "Deselect All"
end
Suggested labels
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/core/components/core/modals/existing-issues-list-modal.tsx (1)
325-329: Consider improving the select/deselect button's clarity.When some (but not all) issues are manually selected, the button will still display "Select All", which might be confusing.
Consider enhancing the button label to show the number of selected items:
-{selectedIssues.length === issues.length - ? t("issue.select.deselect_all") - : t("issue.select.select_all")} +{selectedIssues.length === filteredIssues.length + ? t("issue.select.deselect_all") + : `${t("issue.select.select_all")} (${selectedIssues.length}/${filteredIssues.length})`}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (20)
packages/i18n/src/locales/cs/translations.json(1 hunks)packages/i18n/src/locales/de/translations.json(1 hunks)packages/i18n/src/locales/en/translations.json(1 hunks)packages/i18n/src/locales/es/translations.json(1 hunks)packages/i18n/src/locales/fr/translations.json(1 hunks)packages/i18n/src/locales/id/translations.json(1 hunks)packages/i18n/src/locales/it/translations.json(1 hunks)packages/i18n/src/locales/ja/translations.json(1 hunks)packages/i18n/src/locales/ko/translations.json(1 hunks)packages/i18n/src/locales/pl/translations.json(1 hunks)packages/i18n/src/locales/pt-BR/translations.json(1 hunks)packages/i18n/src/locales/ro/translations.json(1 hunks)packages/i18n/src/locales/ru/translations.json(1 hunks)packages/i18n/src/locales/sk/translations.json(1 hunks)packages/i18n/src/locales/tr-TR/translations.json(1 hunks)packages/i18n/src/locales/ua/translations.json(1 hunks)packages/i18n/src/locales/vi-VN/translations.json(1 hunks)packages/i18n/src/locales/zh-CN/translations.json(1 hunks)packages/i18n/src/locales/zh-TW/translations.json(1 hunks)web/core/components/core/modals/existing-issues-list-modal.tsx(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
web/core/components/core/modals/existing-issues-list-modal.tsx (1)
packages/i18n/src/store/index.ts (1)
t(233-254)
🔇 Additional comments (21)
packages/i18n/src/locales/es/translations.json (1)
1085-1087: Bulk selection keys correctly localized
Theselect_allanddeselect_allkeys have been added alongsideadd_selectedunder"issue.select". The Spanish translations"Seleccionar todo"and"Deseleccionar todo"accurately reflect the intended UI text and match the format used in other locale files.packages/i18n/src/locales/zh-TW/translations.json (1)
1084-1086: Bulk selection keys correctly localized
The new keysselect_allanddeselect_allunder"issue.select"are translated as"全選"and"取消全選", respectively, which are precise and consistent with the other locales.packages/i18n/src/locales/ko/translations.json (1)
1084-1086: Added bulk selection keys for issue.select in Korean localeThe keys
add_selected,select_all, anddeselect_allhave been correctly added under theissue.selectsection with accurate Korean translations. This aligns with the new UI feature for selecting and deselecting all work items.packages/i18n/src/locales/pt-BR/translations.json (1)
1084-1086: Added bulk selection keys for issue.select in pt-BR localeThe new keys
add_selected,select_all, anddeselect_allare correctly inserted under theissue.selectsection with accurate Portuguese translations for the bulk selection UI feature.packages/i18n/src/locales/de/translations.json (1)
1082-1084: Add bulk selection localization keys in German translation
The"add_selected","select_all", and"deselect_all"entries underissue.selectare correctly added with accurate German translations. JSON syntax and trailing commas are valid.packages/i18n/src/locales/pl/translations.json (1)
1084-1087: Add bulk selection localization keys in Polish translation
The"add_selected","select_all", and"deselect_all"entries underissue.selectare correctly added with accurate Polish translations. JSON syntax and trailing commas are valid.packages/i18n/src/locales/vi-VN/translations.json (1)
1083-1085: Add localized strings for bulk selection toggle
The new keysselect_allanddeselect_allunderissue.selectcorrectly provide the Vietnamese labels for the "Select All"/"Deselect All" feature. They align with the existing translation style and match the PR’s intent.packages/i18n/src/locales/tr-TR/translations.json (1)
1085-1087: Add localized strings for bulk selection toggle
The entries forselect_allanddeselect_allunderissue.selectcorrectly supply the Turkish labels for the new bulk selection button. They follow the file’s conventions and support the feature.packages/i18n/src/locales/cs/translations.json (1)
1082-1084: Approve Czech translation additions
The keys"add_selected","select_all", and"deselect_all"under"issue.select"are correctly localized in Czech, and the JSON structure remains valid without introducing trailing commas.packages/i18n/src/locales/ua/translations.json (1)
1084-1086: Approve Ukrainian translation additions
The new keys"add_selected","select_all", and"deselect_all"are properly translated into Ukrainian and inserted with valid JSON syntax.packages/i18n/src/locales/en/translations.json (2)
917-919: Approve new English translation keys
The keysadd_selected,select_all, anddeselect_allhave been added correctly under theissue.selectsection and follow the existing naming and phrasing conventions.
917-919: Inconsistent AI-generated summary
The AI-generated summary mentions onlyselect_allanddeselect_all, but this diff also adds theadd_selectedkey. Please update the summary to accurately reflect all added keys.Likely an incorrect or invalid review comment.
packages/i18n/src/locales/fr/translations.json (1)
1083-1085: Approve French translation additions
The new keysadd_selected,select_all, anddeselect_allare translated accurately ("Ajouter les éléments de travail sélectionnés","Sélectionner tout", and"Tout désélectionner") and match the existing style in this locale.packages/i18n/src/locales/id/translations.json (1)
1082-1084: Correctly added Indonesian translations for bulk select/deselect
The newselect_allanddeselect_allkeys under"issue.select"align with the added UI toggle functionality and follow the existing JSON structure. Ensure the component uses these keys for the Indonesian locale.packages/i18n/src/locales/ja/translations.json (1)
1083-1085: Correctly added Japanese translations for bulk select/deselect
The newselect_allanddeselect_allentries under"issue.select"are properly inserted and consistent with the rest of the file. Verify that the modal footer button references these keys in the Japanese locale.packages/i18n/src/locales/it/translations.json (1)
1081-1083: New translation entries for bulk selection
The keysselect_allanddeselect_allhave been correctly added under theissue.selectsection with appropriate Italian values. JSON syntax remains valid, and there’s no stray trailing comma.packages/i18n/src/locales/zh-CN/translations.json (1)
1083-1085: New translation entries for bulk selection
The keysselect_allanddeselect_allare properly inserted underissue.selectwith accurate Chinese translations. JSON formatting is correct (no extra comma).packages/i18n/src/locales/ru/translations.json (1)
1084-1086: Approve translation additions for bulk selection
Added keysselect_all("Выбрать все") anddeselect_all("Снять выделение со всех") underissue.select. The translations are accurate, follow existing style, and maintain consistency with other locale files.packages/i18n/src/locales/sk/translations.json (1)
1084-1086: Approve translation additions for bulk selection
Added keysselect_all("Vybrať všetko") anddeselect_all("Zrušiť výber všetkého") underissue.select. The translations are accurate, match naming conventions, and align with other locale implementations.packages/i18n/src/locales/ro/translations.json (1)
1082-1084: Appropriate Romanian translations added for bulk selection actions.The new translation keys for "Select All" and "Deselect All" are appropriately implemented in Romanian, maintaining consistency with other localization files.
web/core/components/core/modals/existing-issues-list-modal.tsx (1)
113-115: Selection toggle handler implementation looks good.This handler correctly toggles between selecting all issues and deselecting all issues based on the current selection state.
pqhung3007
force-pushed
the
chore/select-deselect
branch
from
f5df5ea to
229f719
Compare
pqhung3007
force-pushed
the
chore/select-deselect
branch
from
229f719 to
012a019
Compare
|
@sriramveeraghanta Can you look at this PR once again to see if it's ready to be merged? Thank you. |
|
@pqhung3007 This PR looks good, and we will proceed with merging it. However, to maintain consistency, the same changes should also be applied to the Modules. Would you like to create another PR to incorporate these changes into the Modules? |
|
@sriramveeraghanta I see that this component |
… work item (#7045) * chore: add select all/deselect all functionality * chore: update button display logic by CR
3 participants
Description
This PR added the ability to select/deselect all work items when adding existing work item to a new cycle for faster bulk selection.
Type of Change
Screenshots and Media (if applicable)
Screen.Recording.2025-05-12.at.15.38.58.mov
Test Scenarios
References
Summary by CodeRabbit
New Features
Localization