fix: next path in auth wrapper #7050
Conversation
WalkthroughThe Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🔭 Outside diff range comments (1)
web/core/lib/wrappers/authentication-wrapper.tsx (1)
53-135: 🛠️ Refactor suggestionConsider a more robust approach for handling next_path across redirects
While centralizing the next_path logic is a good idea, the current implementation has several issues with URL construction. A better approach would be to create a helper function that properly constructs URLs with query parameters.
// Add a helper function for constructing URLs with next_path const createRedirectURL = (basePath: string, nextPathParam?: string | null) => { return nextPathParam ? `${basePath}?next_path=${nextPathParam}` : basePath; }; // Then use it consistently in all redirect calls: router.push(createRedirectURL('/onboarding', nextPath)); router.push(createRedirectURL('/', nextPath));This approach would:
- Centralize URL construction logic
- Prevent nested query parameters
- Ensure consistent handling of the next_path parameter
- Make the code more maintainable
🧰 Tools
🪛 Biome (1.9.4)
[error] 129-129: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/core/lib/wrappers/authentication-wrapper.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/lib/wrappers/authentication-wrapper.tsx (1)
103-103:⚠️ Potential issueFix URL construction with potentially improper query parameter encoding
This line has two issues:
- It creates a URL with a query parameter immediately after the root slash (
/?)- It can create nested query parameters which browsers may not handle correctly
- router.push(`/${pathnameWithNextPath ? `?next_path=${pathnameWithNextPath}` : ``}`); + router.push(nextPath ? `/?next_path=${nextPath}` : `/`);Likely an incorrect or invalid review comment.
Description
In auth wrapper, the next_path in some cases wasn't getting carried forward. This PR fixes that issue.
Summary by CodeRabbit