-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WEB-4432]fix: webhooks translation #7332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe translation keys for the secret key title and message in the web-hooks form component were updated to new keys. No changes were made to the component's structure or logic; only the identifiers for the translation strings were modified. Changes
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/core/components/web-hooks/form/secret-key.tsx (2)
64-70: Hard-coded success message bypasses translation layer
"New key regenerated successfully."is user-facing text but skipst().
For consistency and easier localisation, move it to the messages file and reference it via a key, e.g.:- message: "New key regenerated successfully.", + message: t("workspace_settings.settings.webhooks.secret_key.regenerated"),Same applies to the error fallback (
something_went_wrong_please_try_again) if it is not already centralised.
90-92: Option labels are hard-coded
"View secret key"/"Copy secret key"are also visible strings. Consider wrapping them witht()so they can be translated:- { label: "View secret key", Icon: shouldShowKey ? EyeOff : Eye, onClick: toggleShowKey, key: "eye" }, - { label: "Copy secret key", Icon: Copy, onClick: handleCopySecretKey, key: "copy" }, + { label: t("workspace_settings.settings.webhooks.view_secret_key"), Icon: shouldShowKey ? EyeOff : Eye, onClick: toggleShowKey, key: "eye" }, + { label: t("workspace_settings.settings.webhooks.copy_secret_key"), Icon: Copy, onClick: handleCopySecretKey, key: "copy" },This keeps all UI text translatable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/core/components/web-hooks/form/secret-key.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/web/core/components/web-hooks/form/secret-key.tsx (1)
packages/i18n/src/store/index.ts (1)
t(211-232)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
Description
This update fixes the translation key mismatch for webhooks
Type of Change
Summary by CodeRabbit