Skip to content

Conversation

@vamsikrishnamathala
Copy link
Member

@vamsikrishnamathala vamsikrishnamathala commented Jul 3, 2025

Description

This update fixes the translation key mismatch for webhooks

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Summary by CodeRabbit

  • Style
    • Updated translation keys for the secret key title and message in the webhooks form to improve consistency.

@vamsikrishnamathala vamsikrishnamathala self-assigned this Jul 3, 2025
@vamsikrishnamathala vamsikrishnamathala added the 🐛bug Something isn't working label Jul 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2025

Walkthrough

The translation keys for the secret key title and message in the web-hooks form component were updated to new keys. No changes were made to the component's structure or logic; only the identifiers for the translation strings were modified.

Changes

File(s) Change Summary
apps/web/core/components/web-hooks/form/secret-key.tsx Updated translation keys for secret key title and message.

Suggested labels

🌐frontend

Poem

In the land of keys and secret things,
A rabbit hops and softly sings.
Translation tags now shine anew,
With titles clear and messages true.
No logic changed, just words refined—
A gentle tweak for peace of mind!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented Jul 3, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
apps/web/core/components/web-hooks/form/secret-key.tsx (2)

64-70: Hard-coded success message bypasses translation layer

"New key regenerated successfully." is user-facing text but skips t().
For consistency and easier localisation, move it to the messages file and reference it via a key, e.g.:

-          message: "New key regenerated successfully.",
+          message: t("workspace_settings.settings.webhooks.secret_key.regenerated"),

Same applies to the error fallback (something_went_wrong_please_try_again) if it is not already centralised.


90-92: Option labels are hard-coded

"View secret key" / "Copy secret key" are also visible strings. Consider wrapping them with t() so they can be translated:

-  { label: "View secret key", Icon: shouldShowKey ? EyeOff : Eye, onClick: toggleShowKey, key: "eye" },
-  { label: "Copy secret key", Icon: Copy, onClick: handleCopySecretKey, key: "copy" },
+  { label: t("workspace_settings.settings.webhooks.view_secret_key"), Icon: shouldShowKey ? EyeOff : Eye, onClick: toggleShowKey, key: "eye" },
+  { label: t("workspace_settings.settings.webhooks.copy_secret_key"), Icon: Copy, onClick: handleCopySecretKey, key: "copy" },

This keeps all UI text translatable.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f27ec0 and a0be2ee.

📒 Files selected for processing (1)
  • apps/web/core/components/web-hooks/form/secret-key.tsx (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/web/core/components/web-hooks/form/secret-key.tsx (1)
packages/i18n/src/store/index.ts (1)
  • t (211-232)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)

@sriramveeraghanta sriramveeraghanta merged commit 75235f2 into preview Jul 3, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-webhooks_translation branch July 3, 2025 09:35
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants