-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[WEB-4858]chore: updated content for error page #7766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
WalkthroughThe error page component was simplified: auth-related imports and the sign-out flow were removed, external support links were added and rendered from a Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant E as ErrorPage
participant R as Router
participant B as Browser
U->>E: View error page
Note over E: Renders mapped external anchors and "Go to home" button
U->>E: Click external link
E-->>B: Anchor navigates to external URL
B-->>U: External page opens
U->>E: Click "Go to home"
E->>R: router.push("/")
R-->>B: Navigate to home route
B-->>U: Home page loads
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. ✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (3)
apps/web/app/error.tsx (3)
12-28: Preferhrefovervalueand freeze the map.Clearer naming and tighter types help avoid misuse.
-const linkMap = [ +const linkMap = [ { key: "mail_to", label: "Contact Support", - value: "mailto:support@plane.so", + href: "mailto:support@plane.so", }, { key: "status", label: "Status Page", - value: "https://status.plane.so/", + href: "https://status.plane.so/", }, { key: "twitter_handle", label: "@planepowers", - value: "https://x.com/planepowers", + href: "https://x.com/planepowers", }, -]; +] as const;
52-52: A11y: hide emoji from screen readers.Screen readers can read the emoji literally; hide or label it.
- 🚧 Looks like something went wrong! + <span aria-hidden="true">🚧</span> Looks like something went wrong!
60-73: Minor a11y + align withhrefrename.Add a descriptive title and switch to
href.- href={link.value} + href={link.href} + title={`${link.label} (opens in a new tab)`}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/app/error.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/web/app/error.tsx (1)
10-10: LGTM on UI import.Nothing to flag here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
apps/web/app/error.tsx (1)
57-58: Fix grammar and punctuation in user-facing copy.
Small but visible UX issue; same as previously noted.- We track these errors automatically and working on getting things back up and running. If the problem - persists feel free to contact us. In the meantime, try refreshing. + We track errors automatically and are working to get things back up and running. If the problem + persists, please contact us. In the meantime, try refreshing.
🧹 Nitpick comments (4)
apps/web/app/error.tsx (4)
54-54: Nit: make the emoji decorative for screen readers.
Wrap the emoji so it’s ignored by AT.- 🚧 Looks like something went wrong! + <span aria-hidden="true" className="mr-1">🚧</span> Looks like something went wrong!
62-75: Make link list semantic and improve a11y; remove extra wrapper.
- Use a list (ul/li) for a set of links.
- Add nofollow for external targets; add an aria-label to announce “opens in a new tab”.
- Drop the extra div per item.
- <div className="flex items-center justify-start gap-6 mt-1"> - {linkMap.map((link) => ( - <div key={link.key}> - <a - href={link.value} - target="_blank" - rel="noopener noreferrer" - className="text-custom-primary-100 hover:underline text-sm" - > - {link.label} - </a> - </div> - ))} - </div> + <ul className="flex items-center justify-start gap-6 mt-1" role="list"> + {linkMap.map((link) => ( + <li key={link.key}> + <a + href={link.value} + target="_blank" + rel="noopener noreferrer nofollow" + className="text-custom-primary-100 hover:underline text-sm" + aria-label={`${link.label} (opens in a new tab)`} + > + {link.label} + </a> + </li> + ))} + </ul>
77-81: Optional: expose Next’s reset() and add a “Try again” action.
Helps recover without navigation.<div className="flex items-center justify-start gap-6"> + <Button variant="neutral" size="md" onClick={reset}> + Try again + </Button> <Button variant="primary" size="md" onClick={() => router.push("/")}> Go to home </Button> </div>And update the component signature (outside the changed lines):
export default function CustomErrorComponent({ reset }: { reset: () => void }) {
13-29: Freeze linkMap and confirm external endpoints.Verified support@plane.so, https://status.plane.so/, and https://x.com/planepowers are official. Apply this minimal change in apps/web/app/error.tsx (lines 13–29) to narrow types and prevent mutation:
-]; +] as const;
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/app/error.tsx(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/web/app/error.tsx (1)
apps/web/core/hooks/use-app-router.tsx (1)
useAppRouter(4-4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/web/app/error.tsx (3)
6-7: LGTM: imports are lean and appropriate for a client component.
34-34: LGTM: using the app router for navigation is correct here.
78-80: LGTM: “Go to home” now navigates to “/” instead of reloading.
* chore: added access for workspace admin to edit project settings * chore: workspace admin to update members details * chore: workspace admin to label, state, workflow settings * Revert "chore: added access for workspace admin to edit project settings" This reverts commit 803b56514887339d884eaef170de8a9e4ecfda8c. * chore: updated worspace admin access for projects * Revert "chore: workspace admin to update members details" This reverts commit ac465d618d7a89ef696db3484e515957b6b5e264. * Revert "chore: workspace admin to label, state, workflow settings" This reverts commit f01a89604e71792096cbae8e029cac160ea209fb. * chore: workspace admin access in permission classes and decorator * chore: check for teamspace members * chore: refactor permission logic * [WIKI-632] chore: accept additional props for document collaborative editor (#7718) * chore: add collaborative document editor extended props * fix: additional rich text extension props * fix: formatting * chore: add types to the trailing node extension --------- Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> * [WEB-4854] chore: project admin accesss to workspace admins (#7749) * chore: project admin accesss to workspace admins * chore: frontend changes * chore: remove console.log * chore: refactor permission decorator * chore: role enum * chore: rearrange role_choices * Potential fix for code scanning alert no. 636: URL redirection from remote source (#7760) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * [WEB-4441]fix: members account type dropdown position #7759 * [WEB-4857] fix: applied filters root update #7750 * [WEB-4858]chore: updated content for error page (#7766) * chore: updated content for error page * chore: updated btn url * fix: merge conflicts * fix: merge conflicts * fix: use enum for roles --------- Co-authored-by: vamsikrishnamathala <matalav55@gmail.com> Co-authored-by: Lakhan Baheti <94619783+1akhanBaheti@users.noreply.github.com> Co-authored-by: Aaryan Khandelwal <aaryankhandu123@gmail.com> Co-authored-by: sriram veeraghanta <veeraghanta.sriram@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Vamsi Krishna <46787868+vamsikrishnamathala@users.noreply.github.com>
* chore: updated content for error page * chore: updated btn url
Description
This PR updated the content for error page in the web application.
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
New Features
Refactor