Skip to content

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Oct 15, 2025

Description

This PR includes improvement for nav button color.

Type of Change

  • Improvement

Summary by CodeRabbit

  • Style
    • Updated inactive sidebar navigation text color for improved readability and consistency.
    • Applied the new text color across project settings navigation, settings sidebar items, and general sidebar navigation.
    • Active state styling remains unchanged; only non-active text appearance is adjusted.
    • No changes to navigation behavior or interaction.

@anmolsinghbhatia anmolsinghbhatia self-assigned this Oct 15, 2025
Copilot AI review requested due to automatic review settings October 15, 2025 13:30
@makeplane
Copy link

makeplane bot commented Oct 15, 2025

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Walkthrough

Updated inactive text color classes from text-custom-sidebar-text-300 to text-custom-sidebar-text-200 across sidebar navigation components. Active state classes and logic remain unchanged. No public APIs or control flow were modified.

Changes

Cohort / File(s) Change Summary
Settings sidebar nav items
apps/web/core/components/settings/.../nav-item-children.tsx, apps/web/core/components/settings/sidebar/nav-item.tsx
Adjusted inactive text class from text-custom-sidebar-text-300 to text-custom-sidebar-text-200; active state unchanged.
App sidebar navigation
apps/web/core/components/sidebar/sidebar-navigation.tsx
Updated non-active state text color from text-custom-sidebar-text-300 to text-custom-sidebar-text-200; no logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nibble through the stylesheet rows,
From 300’s dusk to 200’s glow.
Sidebar whispers, softer hue—
Active stays, while idle grew.
Thump-thump! My paws approve the tone,
A subtle shade, neatly sown. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description only includes the change summary and type but omits the required sections for screenshots, test scenarios, and references as outlined in the repository template. Please add the "Screenshots and Media" section (or note none are needed), document the test scenarios you performed to verify the color change, and include any related issue or ticket links in the "References" section to fully satisfy the template requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[WEB-5154] chore: nav button text color updated" concisely describes the primary change of updating the navigation button text color and aligns with the changeset’s focus on styling; including the ticket reference and prefix is common in this codebase.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-nav-button-text-color

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b106cb and bff3c67.

📒 Files selected for processing (3)
  • apps/web/core/components/settings/project/sidebar/nav-item-children.tsx (1 hunks)
  • apps/web/core/components/settings/sidebar/nav-item.tsx (1 hunks)
  • apps/web/core/components/sidebar/sidebar-navigation.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and lint web apps
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/web/core/components/sidebar/sidebar-navigation.tsx (1)

21-21: LGTM! Consistent styling improvement.

The inactive navigation text color has been updated to text-custom-sidebar-text-200, making it lighter than the previous text-custom-sidebar-text-300. This change is applied consistently across all navigation components in this PR.

apps/web/core/components/settings/project/sidebar/nav-item-children.tsx (1)

64-64: LGTM! Consistent with other navigation components.

The inactive state text color has been updated to text-custom-sidebar-text-200, matching the same change applied in the other navigation components within this PR.

apps/web/core/components/settings/sidebar/nav-item.tsx (1)

45-45: LGTM! Completes the consistent color update.

The inactive navigation text color has been updated to text-custom-sidebar-text-200, completing the consistent styling improvement across all navigation components in this PR.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates sidebar navigation components to use a new text color token for inactive nav items, aligning with the design change for improved nav button text color.

  • Replace text-custom-sidebar-text-300 with text-custom-sidebar-text-200 for inactive states
  • Apply the change consistently across sidebar, settings sidebar, and project settings sidebar children

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/web/core/components/sidebar/sidebar-navigation.tsx Updates inactive nav text color token to text-custom-sidebar-text-200
apps/web/core/components/settings/sidebar/nav-item.tsx Updates inactive nav text color token to text-custom-sidebar-text-200
apps/web/core/components/settings/project/sidebar/nav-item-children.tsx Updates inactive child nav text color token to text-custom-sidebar-text-200

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pushya22 pushya22 merged commit a8c253a into preview Oct 15, 2025
6 of 8 checks passed
@pushya22 pushya22 deleted the fix-nav-button-text-color branch October 15, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants