-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[WEB-5154] chore: nav button text color updated #7970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
WalkthroughUpdated inactive text color classes from text-custom-sidebar-text-300 to text-custom-sidebar-text-200 across sidebar navigation components. Active state classes and logic remain unchanged. No public APIs or control flow were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates sidebar navigation components to use a new text color token for inactive nav items, aligning with the design change for improved nav button text color.
- Replace text-custom-sidebar-text-300 with text-custom-sidebar-text-200 for inactive states
- Apply the change consistently across sidebar, settings sidebar, and project settings sidebar children
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/web/core/components/sidebar/sidebar-navigation.tsx | Updates inactive nav text color token to text-custom-sidebar-text-200 |
| apps/web/core/components/settings/sidebar/nav-item.tsx | Updates inactive nav text color token to text-custom-sidebar-text-200 |
| apps/web/core/components/settings/project/sidebar/nav-item-children.tsx | Updates inactive child nav text color token to text-custom-sidebar-text-200 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
This PR includes improvement for nav button color.
Type of Change
Summary by CodeRabbit