[WEB-5772] chore: theme switcher code refactor

[anmolsinghbhatia]

Summary by CodeRabbit

• Bug Fixes
  • Theme updates now apply immediately without delay, providing a faster and more responsive user experience when switching themes across the app.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[cursor]

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 20.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[coderabbitai]

Walkthrough

Removed a 1.5-second delay before page reload following theme updates across three preference-related files. All instances now call window.location.reload() immediately upon promise resolution instead of using setTimeout.

Changes

Cohort / File(s)	Summary
Remove delayed reload after theme update apps/web/app/(all)/profile/appearance/page.tsx, apps/web/ce/components/preferences/theme-switcher.tsx, apps/web/core/components/power-k/config/preferences-commands.ts	Removed setTimeout(..., 1500) delay before window.location.reload() calls. Page now reloads immediately upon theme update promise resolution. Error handling and toast notifications remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided. The description is completely missing, lacking all required template sections including type of change, test scenarios, and references.	Add a detailed PR description using the repository template, including type of change (code refactoring), test scenarios confirming immediate reload works correctly, and any related issue references.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: removing the delayed reload timeout and making theme updates reload immediately after promise resolution across multiple files.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore-theme-switcher-code-refactor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[makeplane]

Linked to Plane Work Item(s)

• [WEB-5772] Theme change causes UI flicker when switching between browser tabs

This comment was auto-generated by Plane

[Copilot]

Pull request overview

This PR refactors the theme switcher code by removing the 1500ms delay before page reload across three different theme update implementations.

Key Changes:

• Removed setTimeout wrapper with 1500ms delay before window.location.reload() calls
• Immediate page reload after theme update completes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
apps/web/core/components/power-k/config/preferences-commands.ts	Removed delay in handleUpdateTheme function for power-k preferences commands
apps/web/ce/components/preferences/theme-switcher.tsx	Removed delay in handleThemeChange function in ThemeSwitcher component
apps/web/app/(all)/profile/appearance/page.tsx	Removed delay in handleThemeChange function in ProfileAppearancePage

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bc7080 and 1db5b31.

📒 Files selected for processing (3)

• apps/web/app/(all)/profile/appearance/page.tsx
• apps/web/ce/components/preferences/theme-switcher.tsx
• apps/web/core/components/power-k/config/preferences-commands.ts

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• apps/web/ce/components/preferences/theme-switcher.tsx
• apps/web/app/(all)/profile/appearance/page.tsx
• apps/web/core/components/power-k/config/preferences-commands.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Enable TypeScript strict mode and ensure all files are fully typed

Files:

• apps/web/ce/components/preferences/theme-switcher.tsx
• apps/web/app/(all)/profile/appearance/page.tsx
• apps/web/core/components/power-k/config/preferences-commands.ts

**/*.{js,jsx,ts,tsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with Tailwind plugin for code formatting, run pnpm fix:format

Files:

• apps/web/ce/components/preferences/theme-switcher.tsx
• apps/web/app/(all)/profile/appearance/page.tsx
• apps/web/core/components/power-k/config/preferences-commands.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately

Files:

• apps/web/ce/components/preferences/theme-switcher.tsx
• apps/web/app/(all)/profile/appearance/page.tsx
• apps/web/core/components/power-k/config/preferences-commands.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: CodeQL analysis (javascript-typescript)
• GitHub Check: Analyze (javascript)
• GitHub Check: Build packages