[GIT-44] refactor(auth): add PASSWORD_TOO_WEAK error code#8522
[GIT-44] refactor(auth): add PASSWORD_TOO_WEAK error code#8522sriramveeraghanta merged 10 commits intopreviewfrom
Conversation
…rror handling in password change flow
JayashTripathy
requested review from
Copilot,
dheeru0198 and
vamsikrishnamathala
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis change introduces a new authentication error code Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new error code PASSWORD_TOO_WEAK (5021) to provide more specific error handling for weak passwords in the password change flow. Previously, the system used INVALID_NEW_PASSWORD for this purpose, but this change creates a distinct error code specifically for password strength validation.
Key changes:
- Added
PASSWORD_TOO_WEAKerror code (5021) across frontend and backend - Updated password change endpoint to use the new error code for weak passwords
- Enhanced UI error handling to display field-level validation errors for weak passwords
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/constants/src/auth/index.ts | Added PASSWORD_TOO_WEAK enum value (5021) to the auth error codes |
| apps/web/helpers/authentication.helper.tsx | Added PASSWORD_TOO_WEAK error code, error message, banner alert handling, and passwordErrors array for field-level validation |
| apps/web/app/(all)/profile/security/page.tsx | Updated error handling to display field-level validation errors for password errors using setError |
| apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx | Updated error handling to display field-level validation errors for password errors using setError |
| apps/api/plane/authentication/views/common.py | Changed password strength validation error from INVALID_NEW_PASSWORD to PASSWORD_TOO_WEAK |
| apps/api/plane/authentication/adapter/error.py | Added PASSWORD_TOO_WEAK error code mapping (5021) to the backend authentication error codes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
Outdated
Show resolved
Hide resolved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @apps/api/plane/authentication/views/common.py:
- Around line 82-83: The SetUserPasswordEndpoint currently returns
AUTHENTICATION_ERROR_CODES["INVALID_PASSWORD"] when results["score"] < 3,
causing inconsistency with ChangePasswordEndpoint; update the
SetUserPasswordEndpoint error response to use
AUTHENTICATION_ERROR_CODES["PASSWORD_TOO_WEAK"] and set error_message to
"PASSWORD_TOO_WEAK" for the same results["score"] < 3 branch so both endpoints
return the same error code/message for weak passwords.
🧹 Nitpick comments (1)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (1)
92-108: Verify the duplicate error messaging UX pattern.Password-related errors will display both:
- A toast notification (lines 96-101)
- An inline field error (line 208)
This double notification might be intentional to ensure users don't miss the validation feedback, but please confirm this is the desired UX.
Optional: Line 106 -
.toString()is likely redundant.Based on the
authErrorHandlerimplementation,errorInfo.messageis already a string. The.toString()call is safe but unnecessary.♻️ Optional simplification
if (passwordErrors.includes(code as EAuthenticationErrorCodes)) { setError("new_password", { type: "manual", - message: errorInfo?.message?.toString() || t("auth.common.password.toast.error.message"), + message: errorInfo?.message || t("auth.common.password.toast.error.message"), }); }
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
apps/api/plane/authentication/adapter/error.pyapps/api/plane/authentication/views/common.pyapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsxapps/web/app/(all)/profile/security/page.tsxapps/web/helpers/authentication.helper.tsxpackages/constants/src/auth/index.ts
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}
📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
**/*.{ts,tsx,mts,cts}: Useconsttype parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfiesoperator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitisreturn types in filter/check functions
UseNoInfer<T>utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true)blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusingdeclarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" }for import attributes; avoid deprecatedassertsyntax (TypeScript 5.3/5.8+)
Useimport typeexplicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntaxflag
Use.ts,.mts,.ctsextensions inimport typestatements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" }for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSetmethods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy/Map.groupBystandard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers()for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuperin classes (TypeScript 5....
Files:
packages/constants/src/auth/index.tsapps/web/app/(all)/profile/security/page.tsxapps/web/helpers/authentication.helper.tsxapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Enable TypeScript strict mode and ensure all files are fully typed
Files:
packages/constants/src/auth/index.tsapps/web/app/(all)/profile/security/page.tsxapps/web/helpers/authentication.helper.tsxapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier with Tailwind plugin for code formatting, run
pnpm fix:format
Files:
packages/constants/src/auth/index.tsapps/web/app/(all)/profile/security/page.tsxapps/web/helpers/authentication.helper.tsxapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately
Files:
packages/constants/src/auth/index.tsapps/web/app/(all)/profile/security/page.tsxapps/web/helpers/authentication.helper.tsxapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
🧠 Learnings (2)
📚 Learning: 2025-07-08T13:41:19.928Z
Learnt from: prateekshourya29
Repo: makeplane/plane PR: 7363
File: apps/web/helpers/react-hook-form.helper.ts:9-19
Timestamp: 2025-07-08T13:41:19.928Z
Learning: In the apps/web/helpers/react-hook-form.helper.ts file, the getNestedError function's FieldError detection logic using "message" property check is sufficient for their use case, and more robust type checking is not required.
Applied to files:
apps/web/app/(all)/profile/security/page.tsxapps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
📚 Learning: 2025-12-23T14:18:32.899Z
Learnt from: dheeru0198
Repo: makeplane/plane PR: 8339
File: apps/api/plane/db/models/api.py:35-35
Timestamp: 2025-12-23T14:18:32.899Z
Learning: Django REST Framework rate limit strings are flexible: only the first character of the time unit matters. Acceptable formats include: "60/s", "60/sec", "60/second" (all equivalent), "60/m", "60/min", "60/minute" (all equivalent), "60/h", "60/hr", "60/hour" (all equivalent), and "60/d", "60/day" (all equivalent). Abbreviations like "min" are valid and do not need to be changed to "minute". Apply this guidance to any Python files in the project that configure DRF throttling rules.
Applied to files:
apps/api/plane/authentication/views/common.pyapps/api/plane/authentication/adapter/error.py
🧬 Code graph analysis (2)
apps/web/app/(all)/profile/security/page.tsx (1)
apps/web/helpers/authentication.helper.tsx (1)
passwordErrors(435-438)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (1)
apps/web/helpers/authentication.helper.tsx (2)
authErrorHandler(369-433)passwordErrors(435-438)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Lint API
- GitHub Check: CodeQL analysis (javascript-typescript)
- GitHub Check: CodeQL analysis (python)
- GitHub Check: Agent
- GitHub Check: Analyze (javascript)
- GitHub Check: Build packages
🔇 Additional comments (7)
packages/constants/src/auth/index.ts (1)
111-111: LGTM!The new error code is well-placed in the password strength section and follows the existing numbering convention.
apps/api/plane/authentication/adapter/error.py (1)
12-12: LGTM!The error code mapping is correctly placed and consistent with the frontend definition.
apps/web/helpers/authentication.helper.tsx (1)
44-44: LGTM! Clean error handling additions.The changes are well-structured:
- Error code and message mapping follow existing patterns
- Banner alert handling is consistent with other error codes
- The new
passwordErrorsexport provides a clean way to group password-related errors for field-level validationAlso applies to: 142-145, 421-421, 435-438
apps/web/app/(all)/profile/security/page.tsx (1)
17-17: LGTM! Excellent UX improvement with field-level errors.The implementation correctly uses react-hook-form's
setErrorto display server-side password validation errors directly on thenew_passwordfield, in addition to the toast notification. This provides immediate, contextual feedback to users.The error handling logic is clean:
- Checks if the error code is password-related using the
passwordErrorsarray- Sets a manual field error with the appropriate message
- Safely converts ReactNode messages to strings with a fallback
Also applies to: 56-56, 101-107, 208-210
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (3)
16-17: LGTM! Clean imports for the new error handling.The imports are appropriate and necessary for the server-side password validation feedback feature.
56-56: LGTM! Proper integration of setError for programmatic field validation.The addition of
setErrorenables server-side validation messages to be displayed inline on the form field.
208-208: LGTM! Proper inline error display for server-side validation.The error rendering correctly displays the manual field error set by
setError, providing immediate feedback to users when password validation fails server-side.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
@apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx:
- Around line 91-109: The catch block must guard against non-object/null thrown
values and avoid calling includes with undefined: first check that error is an
object and not null (e.g., if (typeof error !== "object" || error === null) {
set a generic toast via setToast and return; }), then safely extract code (const
err = error as Error & { error_code?: string }; const code =
err.error_code?.toString();), and only call passwordErrors.includes(...) if code
is a non-empty string (e.g., if (typeof code === "string" && code &&
passwordErrors.includes(code as EAuthenticationErrorCodes)) {
setError("new_password", ... ) }). Ensure authErrorHandler is only called with a
defined code and fall back to generic messages when code is absent.
🧹 Nitpick comments (2)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (2)
16-17: Consider consolidating the type import into the named import (optional).
Current approach is correct; if you want to reduce import lines, TS supportstypemodifiers in named imports.
208-208: Nice UX improvement: inlinenew_passworderror rendering.
Optional: considerrole="alert"(or whatever your form-error convention is) so screen readers announce updates.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}
📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
**/*.{ts,tsx,mts,cts}: Useconsttype parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfiesoperator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitisreturn types in filter/check functions
UseNoInfer<T>utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true)blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusingdeclarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" }for import attributes; avoid deprecatedassertsyntax (TypeScript 5.3/5.8+)
Useimport typeexplicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntaxflag
Use.ts,.mts,.ctsextensions inimport typestatements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" }for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSetmethods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy/Map.groupBystandard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers()for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuperin classes (TypeScript 5....
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Enable TypeScript strict mode and ensure all files are fully typed
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier with Tailwind plugin for code formatting, run
pnpm fix:format
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
🧬 Code graph analysis (1)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (1)
apps/web/helpers/authentication.helper.tsx (2)
authErrorHandler(369-433)passwordErrors(435-438)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check:lint
🔇 Additional comments (2)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (2)
52-59: Good:setErrorwired up for field-level server validation.
This aligns well with react-hook-form usage for server-side validation feedback.
16-17:EAuthenticationErrorCodesis an enum with string values;PASSWORD_TOO_WEAKis both mapped inauthErrorHandlerand included inpasswordErrors.Since
PASSWORD_TOO_WEAKis in thebannerAlertErrorCodesarray (line 421),authErrorHandlerwill always return aTAuthErrorInfoobject (notundefined) for this error code. However, the code has type safety issues:codeis cast asEAuthenticationErrorCodeswithout validation, and the.toString()call onerr.error_codeis redundant if it's already a string. Additionally, calling.toString()onmessage(aReactNode) is problematic—it works for the string literal inPASSWORD_TOO_WEAKbut would fail for complex React elements.Consider validating the error code against known values before casting, removing the unnecessary
toString()calls, and handlingmessageas aReactNodewithout conversion.⛔ Skipped due to learnings
Learnt from: prateekshourya29 Repo: makeplane/plane PR: 7363 File: apps/web/helpers/react-hook-form.helper.ts:9-19 Timestamp: 2025-07-08T13:41:19.928Z Learning: In the apps/web/helpers/react-hook-form.helper.ts file, the getNestedError function's FieldError detection logic using "message" property check is sufficient for their use case, and more robust type checking is not required.
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/security/page.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (1)
91-108: Inconsistent message handling between toast and field error.Line 100 guards against non-string messages with
typeof errorInfo?.message === "string", but line 106 useserrorInfo?.message?.toString()which could produce unexpected results ifmessageis not a string (e.g.,"[object Function]").For consistency, use the same resolution logic:
♻️ Suggested fix
if (code && passwordErrors.includes(code as EAuthenticationErrorCodes)) { + const fieldErrorMessage = + typeof errorInfo?.message === "string" ? errorInfo.message : t("auth.common.password.toast.error.message"); setError("new_password", { type: "manual", - message: errorInfo?.message?.toString() || t("auth.common.password.toast.error.message"), + message: fieldErrorMessage, }); }
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsxapps/web/app/(all)/profile/security/page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/web/app/(all)/profile/security/page.tsx
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,mts,cts}
📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)
**/*.{ts,tsx,mts,cts}: Useconsttype parameters for more precise literal inference in TypeScript 5.0+
Use thesatisfiesoperator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicitisreturn types in filter/check functions
UseNoInfer<T>utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing inswitch(true)blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacyexperimentalDecorators
Useusingdeclarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Usewith { type: "json" }for import attributes; avoid deprecatedassertsyntax (TypeScript 5.3/5.8+)
Useimport typeexplicitly when importing types to ensure they are erased during compilation, respectingverbatimModuleSyntaxflag
Use.ts,.mts,.ctsextensions inimport typestatements (TypeScript 5.2+)
Useimport type { Type } from "mod" with { "resolution-mode": "import" }for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize newSetmethods likeunion,intersection, etc., when available (TypeScript 5.5+)
UseObject.groupBy/Map.groupBystandard methods for grouping instead of external libraries (TypeScript 5.4+)
UsePromise.withResolvers()for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted,toSpliced,with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields viasuperin classes (TypeScript 5....
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Enable TypeScript strict mode and ensure all files are fully typed
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Use Prettier with Tailwind plugin for code formatting, run
pnpm fix:format
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately
Files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
🧠 Learnings (2)
📚 Learning: 2025-07-08T13:41:19.928Z
Learnt from: prateekshourya29
Repo: makeplane/plane PR: 7363
File: apps/web/helpers/react-hook-form.helper.ts:9-19
Timestamp: 2025-07-08T13:41:19.928Z
Learning: In the apps/web/helpers/react-hook-form.helper.ts file, the getNestedError function's FieldError detection logic using "message" property check is sufficient for their use case, and more robust type checking is not required.
Applied to files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
📚 Learning: 2025-12-12T15:20:36.542Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-12T15:20:36.542Z
Learning: Applies to **/*.{js,jsx,ts,tsx} : Use try-catch with proper error types and log errors appropriately
Applied to files:
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx
🧬 Code graph analysis (1)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (1)
apps/web/helpers/authentication.helper.tsx (2)
authErrorHandler(369-433)passwordErrors(435-438)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: check:lint
- GitHub Check: check:types
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/web/app/(all)/[workspaceSlug]/(settings)/settings/account/security/page.tsx (3)
16-17: LGTM!The import of
passwordErrorsalongsideauthErrorHandleris appropriate and follows the existing pattern.
52-59: LGTM!The
setErrordestructuring fromuseFormis correct and follows react-hook-form conventions.
207-213: LGTM!The inline error display for
new_passwordfollows the established pattern used for other fields and is properly positioned after the strength indicator.
…actor/passwork-too-weak
JayashTripathy
dismissed stale reviews from vamsikrishnamathala and dheeru0198
via
2f9fcd6
…te error messages
…actor/passwork-too-weak
…cription Added translation for 'stickies' and improved formatting of the automation description in Russian locale.
4 participants
Description
This PR adds PASSWORD_TOO_WEAK error code and update related error handling in password change flow
Type of Change
Summary by CodeRabbit