-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[WEB-6058] chore : add logic to handle save #8614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
📝 WalkthroughWalkthroughA prop Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the cursor position was being reset in the description editor for Intake Work Items. The issue was caused by passing swrDescription={issue.description_html} to the DescriptionInput component, which triggered unnecessary content re-syncing on every MobX store update (including after auto-save).
Changes:
- Removed the
swrDescriptionprop from DescriptionInput in InboxIssueMainContent component
Description
The Intake Work Item was passing
swrDescription={issue.description_html}to DescriptionInput, which caused the editor to re-sync content on every MobX store update (including after auto-save). This triggered the SWR sync effect that resets cursor position.Type of Change
Screenshots and Media (if applicable)
Screen.Recording.2026-02-06.at.2.05.36.PM.mov
Test Scenarios
References
Summary by CodeRabbit