Skip to content

chore: Update healthcheck endpoint in Dockerfile to target /spaces/ path#8674

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-space-dockerfile
Mar 2, 2026
Merged

chore: Update healthcheck endpoint in Dockerfile to target /spaces/ path#8674
sriramveeraghanta merged 1 commit intopreviewfrom
fix-space-dockerfile

Conversation

@akshat5302
Copy link
Member

@akshat5302 akshat5302 commented Mar 2, 2026

Description

This pull request makes a minor update to the health check configuration in the apps/space/Dockerfile.space file. The health check now targets the /spaces/ endpoint instead of the root, and ensures that curl is available in the container.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Chores
    • Enhanced service health monitoring to improve reliability and uptime detection.

Copilot AI review requested due to automatic review settings March 2, 2026 12:47
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9425c66 and 0b9eb33.

📒 Files selected for processing (1)
  • apps/space/Dockerfile.space

📝 Walkthrough

Walkthrough

Updates the Space service Docker configuration by adding curl to the runner image and modifying the HEALTHCHECK directive to verify the /spaces/ endpoint instead of the root path.

Changes

Cohort / File(s) Summary
Docker Configuration
apps/space/Dockerfile.space
Added curl package installation and updated HEALTHCHECK target from / to /spaces/ to correctly verify service availability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • Issue #8392: Directly addresses the same broken healthcheck issue by installing curl and updating the HEALTHCHECK endpoint to /spaces/.
  • Issue #8671: Main changes align with addressing the broken healthcheck where the root endpoint returned 404; the fix adds curl and redirects the health verification to /spaces/.

Poem

🐰 A healthcheck was broken, alas!
The root path was failing the class,
So curl came to play,
And /spaces/ saved the day,
Now the service health checks pass! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: updating the healthcheck endpoint to /spaces/ path in the Dockerfile.
Description check ✅ Passed The description covers the key changes and follows the template structure with Description and Type of Change sections, though Test Scenarios and References sections are missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-space-dockerfile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container healthcheck for the space app image so it probes the app under the /spaces/ base path and ensures the probe tool (curl) is present in the runtime image.

Changes:

  • Install curl in the runtime (runner) stage of apps/space/Dockerfile.space.
  • Change the Docker HEALTHCHECK target from / to /spaces/.

@sriramveeraghanta sriramveeraghanta merged commit 5c9f2a1 into preview Mar 2, 2026
15 of 18 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-space-dockerfile branch March 2, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants