Skip to content

fix(aio): use JSON array double quotes in VOLUME instruction#9099

Open
astarte75 wants to merge 1 commit into
makeplane:previewfrom
astarte75:fix/aio-dockerfile-volume-json-quotes
Open

fix(aio): use JSON array double quotes in VOLUME instruction#9099
astarte75 wants to merge 1 commit into
makeplane:previewfrom
astarte75:fix/aio-dockerfile-volume-json-quotes

Conversation

@astarte75
Copy link
Copy Markdown

@astarte75 astarte75 commented May 16, 2026

Description

deployments/aio/community/Dockerfile declared the VOLUME instruction with single quotes:

VOLUME ['/app/data', '/app/logs']

Docker's JSON (exec) form requires double quotes. With single quotes the line is parsed as the shell form and the bracket/comma tokens become literal anonymous-volume paths ([/app/data, and /app/logs]).

Docker Engine tolerated these non-absolute anonymous volume paths at container create time until Engine 29.5.0, which now rejects them with:

invalid mount config for type "volume": invalid mount path: '[/app/data,' mount path must be absolute

This breaks docker compose up -d --force-recreate and any recreation of the plane-aio-community container on Docker ≥ 29.5.0, making the AIO instance non-upgradeable.

This PR switches to the valid JSON array form:

VOLUME ["/app/data", "/app/logs"]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

N/A — one-line Dockerfile change.

Test Scenarios

  • docker history on an image built from the fixed Dockerfile shows VOLUME ["/app/data" "/app/logs"] and .Config.Volumes = {"/app/data":{}, "/app/logs":{}} (absolute paths).
  • docker create / docker compose up -d --force-recreate succeed on Docker Engine 29.5.0 (previously failed with mount path must be absolute).

References

Fixes #9098

Summary by CodeRabbit

  • Chores
    • Updated Docker image configuration formatting for storage volume declarations.

Review Change Stack

The community AIO Dockerfile declared the VOLUME instruction with
single quotes: VOLUME ['/app/data', '/app/logs']. Docker's JSON (exec)
form requires double quotes; with single quotes the line is parsed as
the shell form and the bracket/comma tokens become literal volume
paths ('[/app/data,' and '/app/logs]').

Docker tolerated these non-absolute anonymous volume paths at container
create time until Engine 29.5.0, which now rejects them with
"invalid mount config for type volume: invalid mount path: '[/app/data,'
mount path must be absolute", breaking `docker compose up --force-recreate`
and any container recreation for the AIO community image.

Switching to the valid JSON array form fixes the parsing.
@astarte75 astarte75 requested a review from mguptahub as a code owner May 16, 2026 18:22
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 16, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d9be692-96ff-414a-ab24-803dd1d55baa

📥 Commits

Reviewing files that changed from the base of the PR and between 50a7b47 and cef79ff.

📒 Files selected for processing (1)
  • deployments/aio/community/Dockerfile

📝 Walkthrough

Walkthrough

The VOLUME directive in deployments/aio/community/Dockerfile line 62 is corrected from single-quoted syntax to double-quoted JSON array syntax. This fixes Docker Engine 29.5.0 validation that rejects non-absolute volume paths created by incorrect JSON parsing.

Changes

Docker VOLUME syntax correction

Layer / File(s) Summary
VOLUME directive syntax correction
deployments/aio/community/Dockerfile
The VOLUME instruction syntax is changed from VOLUME ['/app/data', '/app/logs'] to VOLUME ["/app/data", "/app/logs"], conforming to proper Dockerfile JSON array form with double quotes for Docker Engine 29.5.0 compatibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through Docker land,
Where single quotes were quite unplanned,
Now double quotes stand tall and true,
Volumes parse just as they should do! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the VOLUME instruction syntax by replacing single quotes with double quotes in the JSON array form.
Description check ✅ Passed The description is comprehensive and follows the template, including a detailed explanation, type of change (bug fix), test scenarios, and issue reference (#9098).
Linked Issues check ✅ Passed The PR directly addresses issue #9098 by implementing the suggested one-line fix: changing VOLUME from single quotes to double quotes in the JSON array form.
Out of Scope Changes check ✅ Passed The PR contains only a single-line change that directly addresses the linked issue; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: AIO community Dockerfile VOLUME uses single quotes, breaks container recreate on Docker 29.5.0

2 participants