Skip to content

Align toolchain to a fresh Vite+ project#105

Merged
lifeiscontent merged 1 commit into
mainfrom
chore/match-fresh-viteplus
Jun 16, 2026
Merged

Align toolchain to a fresh Vite+ project#105
lifeiscontent merged 1 commit into
mainfrom
chore/match-fresh-viteplus

Conversation

@lifeiscontent

Copy link
Copy Markdown
Collaborator

The repo was scaffolded with a stale pnpm pin and without the toolchain deps a Vite+ library declares, so this aligns it to what vp create vite:monorepo produces today (the monorepo template ships no packageManager field; the CLI injects the current pnpm at scaffold time, which is now 11.7.0).

Changes:

  • packageManager: pnpm@10.0.0 -> pnpm@11.7.0
  • Declare the toolchain devDeps a fresh Vite+ library ships: typescript, @typescript/native-preview, @types/node, bumpp, vite-plus
  • Add the test / check / prepublishOnly package scripts
  • Move build-script approval from the package.json pnpm.onlyBuiltDependencies field to allowBuilds in pnpm-workspace.yaml, which is where pnpm 11 reads it (esbuild/sharp/workerd build)
  • Run the story tests via vp test instead of a custom Vite Task that shelled out to the raw vitest binary. pnpm 11 no longer links that binary into node_modules/.bin (the catalog aliases vitest to @voidzero-dev/vite-plus-test), and vp test is the Vite+ convention anyway. It reads test.projects from vite.config.ts, so the four-theme matrix still runs.
  • Drop the LAUNCH_EDITOR="$EDITOR" prefix on the storybook script
  • .gitignore: stop ignoring .vscode/settings.json

Notes for reviewers:

  • The lockfile is fully re-resolved by pnpm 11. pnpm 11 enforces a minimumReleaseAge cooldown, so the lockfile was rebuilt to resolve within policy.
  • Verified on pnpm 11.7.0: vp check clean, vp run -r test 700/700 across the four themes, vp run -r build clean (attw passes).

This touches the test config, so it overlaps chore/storybook-theme-instances (PR #97 is separate; the theme-instances branch reworks test.projects). Whichever lands first, I'll rebase the other so they don't collide.

The repo was scaffolded with a stale pnpm pin and without the toolchain deps a
Vite+ library declares. Match what `vp create` produces today.

- packageManager: pnpm@10.0.0 -> pnpm@11.7.0
- Declare the toolchain devDeps a fresh Vite+ library ships: typescript,
  @typescript/native-preview, @types/node, bumpp, vite-plus
- Add the check / prepublishOnly / test package scripts
- Move onlyBuiltDependencies (the package.json `pnpm` field) to `allowBuilds`
  in pnpm-workspace.yaml, which is where pnpm 11 reads it; esbuild/sharp/workerd
  are allowed to build
- Run the story tests via `vp test` (the Vite+ convention) instead of a custom
  Vite Task that shelled out to the raw `vitest` binary, which pnpm 11 no longer
  links into node_modules/.bin
- .gitignore: stop ignoring .vscode/settings.json

Verified on pnpm 11.7.0: `vp check` clean, `vp run -r test` 700/700 across the
four themes, `vp run -r build` clean (attw passes).
Copilot AI review requested due to automatic review settings June 16, 2026 12:17
@github-actions

Copy link
Copy Markdown

📚 Storybook preview: https://pr-105-propel-storybook.vamsi-906.workers.dev

@lifeiscontent lifeiscontent merged commit c411ee2 into main Jun 16, 2026
3 checks passed
@lifeiscontent lifeiscontent deleted the chore/match-fresh-viteplus branch June 16, 2026 12:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the repo’s toolchain with the current Vite+ monorepo scaffold by updating the pnpm pin, moving pnpm’s native-build allowlist to the pnpm 11 location, and switching story tests to the Vite+ (vp) convention.

Changes:

  • Update root packageManager to pnpm@11.7.0 and move build allowlisting to pnpm-workspace.yaml.
  • Update @plane/propel scripts to add check/test/prepublishOnly and run tests via vp test.
  • Remove the custom Vite run.tasks.test task from packages/propel/vite.config.ts and re-resolve the lockfile under pnpm 11.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml Adds allowBuilds configuration for pnpm 11 and retains catalog/overrides setup.
pnpm-lock.yaml Lockfile re-resolved under pnpm 11; records vite/vitest overrides and dependency graph changes.
packages/propel/vite.config.ts Removes the prior cached “run task” test runner configuration in favor of vp test.
packages/propel/package.json Adds check/test/prepublishOnly scripts and new toolchain devDeps; updates Storybook script.
package.json Updates the pnpm pin and removes the old pnpm.onlyBuiltDependencies field.
.gitignore Stops ignoring .vscode/settings.json while continuing to ignore the rest of .vscode/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"tailwindcss": "^4.3.1",
"typescript": "^6.0.3",
"vite-plus": "catalog:",
"vitest": "4.1.9",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants