-
Notifications
You must be signed in to change notification settings - Fork 18
Improve Accessy sync #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Accessy sync #631
Conversation
I want to delete the other one, but can't until the `get_all_members` function is changed. I'm fixing it in an upcoming commit.
That way we don't have to rely on the "phone number hack".
And improve its typing, while at it
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
HalfVoxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But please run a dry-run first to make sure it actually works. Let me know the results :)
|
Dry run worked fine (tested with adding users, removing users and adding/removing groups). But I would need to look into how "resetted" accounts work for the new API endpoint. It won't work if we don't get a phone number to match against the user in the database. Edit: "resetted" accounts do not show up, so we're good to go. |
Reduced from `2 x members` (which was >600 for us) to 3 (best case; worst case `1 x members`)
45d7a96 to
f0562fe
Compare
Reduced the number of API requests needed to fetch user information: