Skip to content

[pull] master from php:master#1005

Merged
pull[bot] merged 2 commits intomakesoftwaresafe:masterfrom
php:master
Jan 15, 2025
Merged

[pull] master from php:master#1005
pull[bot] merged 2 commits intomakesoftwaresafe:masterfrom
php:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Jan 15, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

* ext/soap: Add some SoapServer tests

* ext/soap: Don't call readfile() userland function

We can perform the operation directly, moreover there is no risk of a user disabling the readfile function and defining their own messing up what we are doing.

* ext/soap: Actually throw a SOAP Fault if the WSDL has disappeared
As it always returns SUCCESS and we ignored the return value anyway
@pull pull bot added the ⤵️ pull label Jan 15, 2025
@pull pull bot merged commit effd3f6 into makesoftwaresafe:master Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant