Skip to content

don't let rector replace a function with a method in EventResponseSetter#18

Merged
makomweb merged 1 commit intomasterfrom
martin/rector
Mar 31, 2026
Merged

don't let rector replace a function with a method in EventResponseSetter#18
makomweb merged 1 commit intomasterfrom
martin/rector

Conversation

@makomweb
Copy link
Copy Markdown
Owner

Replacing a working function with a method does not make sense.

@makomweb makomweb merged commit b118f24 into master Mar 31, 2026
2 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.28%. Comparing base (6feaa0a) to head (0974abf).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage     52.28%   52.28%           
  Complexity      316      316           
=========================================
  Files            58       58           
  Lines           962      962           
=========================================
  Hits            503      503           
  Misses          459      459           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant