Conversation
…o module - benchmarks/benchmark_target_mapping.json: replace 4 incorrect geo entries with GEO-1..GEO-9 (correct benchmark functions/files; GEO-7/8/9 as not_measurable with explanations) - PERFORMANCE_EXPECTATIONS.md §8: add GEO-N IDs, v1.8.2 column, formal Ziel-Mapping subsection (§8.1) with GEO-1..GEO-9, proxy table, benchmark tickets; update §7.1 Ursachenmatrix and add §36.4b raw data appendix - artifacts/perf_local/bench_geo_v182_reference.json: v1.8.2 reference run (Google Benchmark JSON, 17 benchmarks covering GEO-1..GEO-6) - tools/verify_benchmark_mapping.py: handle null file/benchmark in not_measurable entries (skip rather than crash) Agent-Logs-Url: https://github.com/makr-code/ThemisDB/sessions/b368f1ab-9dbc-4b6a-baf1-866f45d4a6b2 Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Copilot Request
feat(geo): Complete v1.8.2 Geo target ID mapping and reference runs (GEO-1..GEO-9)
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geo module had 4 incorrectly mapped benchmark entries, missing target IDs for GEO-5/6, and no v1.8.2 reference run — leaving the SLO table with blank cells for all non-Haversine targets.
Changes
benchmarks/benchmark_target_mapping.jsonReplaced the 4-entry geo block (wrong functions, wrong files) with complete GEO-1..GEO-9:
BM_GeoDistance_Haversinebench_hybrid_vector_geo.cppBM_RTree_Contains+ proxyBM_GeoPointInBoundingBoxbench_spatial_index.cppBM_RTree_Intersectsbench_spatial_index.cppBM_RTree_BulkLoadbench_spatial_index.cppBM_GeoCPUExact_StBufferbench_geo_cpu_gpu.cppBM_SpatialJoin_First1000bench_spatial_join.cppnot_measurable(no GeoJSON parse bench)BM_GeoGPU_BatchIntersects(skips on CPU-only)bench_geo_cpu_gpu.cppnot_measurable(GPU-only)not_measurable(GPU-only, no DBSCAN bench)PERFORMANCE_EXPECTATIONS.mdZiel-IDandv1.8.2 Gemessencolumns; all 9 targets now have an entry (GEO-7/8/9 explicitly markednicht messbar)Teilabdeckung→Ziel-ID-Mapping vollständig (v1.8.2)artifacts/perf_local/bench_geo_v182_reference.jsonNew Google Benchmark JSON (17 benchmarks, GEO-1..GEO-6). All measurable SLOs met:
tools/verify_benchmark_mapping.pycheck_files_exist()now skips entries wherefileisnull(valid fornot_measurabletargets) instead of crashing withTypeError.Type of Change
Breaking Change Checklist
VERSIONandCMakeLists.txtdocs/migration/### Removed/### Changedsection updatedTesting
verify_benchmark_mapping.py→ PASS (200 target IDs, 96.5% mapped);perf_expectations_audit.py→ 9 PASS / 1 WARN / 0 FAIL.📚 Research & Knowledge (wenn applicable)
/docs/research/angelegt?/docs/research/implementation_influence/eingetragen?Relevante Quellen:
Checklist
[Unreleased]