PHP 8.5 support, CI improvements, and test coverage#5
Merged
maksimovic merged 5 commits intomasterfrom Mar 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5 +/- ##
============================================
+ Coverage 96.25% 96.59% +0.33%
Complexity 297 297
============================================
Files 17 17
Lines 614 616 +2
============================================
+ Hits 591 595 +4
+ Misses 23 21 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Streamline CI: use direct composer/phpunit CLI calls instead of Docker-based actions - Run code coverage only on PHP 8.5 (speeds up other matrix jobs) - Trigger CI on pull_request in addition to push - Bump actions/checkout to v4, codecov-action to v4 - Install PHP extensions via setup-php instead of phpunit action - Fix implicit nullable parameter deprecation in Process::__construct()
maksimovic
changed the title
- Trigger CI on push to master only + all pull requests (prevents double runs) - Fix Semaphore::remove() to work on PHP 7.x (is_resource() behaves differently for semaphore handles pre-PHP 8) - Replace assertFileDoesNotExist with assertFalse(file_exists()) for PHPUnit 8.5 compat (PHP 7.2)
- Make Semaphore::remove() work cross-version using is_resource() + instanceof SysvSemaphore - Use sem_remove() (not sem_release()) to properly destroy the semaphore - Update testRemoveLockWhenLockReleased to expect success - Add testRemoveAlreadyRemovedSemaphore for the "empty" error path - Add Process tests for getPid(), name(), isStarted(), isStopped() - Add PipeQueue test for reading from empty queue
maksimovic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Process::__construct()for PHP 8.5Semaphore::remove()to work on both PHP 7 and 8 usingsem_remove()assertFileDoesNotExist()with PHPUnit 8.5-compatible alternativeProcess::getPid(),name(),isStarted(),isStopped()PipeQueueempty read andSemaphoredouble-removeTest plan