Skip to content

Conversation

@makspll
Copy link
Owner

@makspll makspll commented Oct 25, 2025

Summary

Closes #485

Also fixes a problem where the strong handles provided to the loading system would lose path information due to going through Assets::get_strong_handle unnecessarily

@semanticdiff-com
Copy link

semanticdiff-com bot commented Oct 25, 2025

@makspll makspll enabled auto-merge (squash) October 25, 2025 12:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

🐰 Bencher Report

Branchfeat/add-script-asset-path-to-function-call-ctxt
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
4,017.40 ns
(-4.12%)Baseline: 4,190.06 ns
4,629.66 ns
(86.78%)
component/access Rhai📈 view plot
🚷 view threshold
4,558.00 ns
(-22.46%)Baseline: 5,878.31 ns
7,153.96 ns
(63.71%)
component/get Lua📈 view plot
🚷 view threshold
2,559.30 ns
(+0.27%)Baseline: 2,552.44 ns
2,902.32 ns
(88.18%)
component/get Rhai📈 view plot
🚷 view threshold
3,373.30 ns
(-23.24%)Baseline: 4,394.69 ns
5,414.67 ns
(62.30%)
conversions/Mut::from📈 view plot
🚷 view threshold
122.52 ns
(+29.08%)Baseline: 94.92 ns
126.92 ns
(96.53%)
conversions/Ref::from📈 view plot
🚷 view threshold
122.06 ns
(+31.20%)Baseline: 93.03 ns
125.54 ns
(97.23%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
331.92 ns
(-7.17%)Baseline: 357.56 ns
453.86 ns
(73.13%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,130.80 ns
(+0.60%)Baseline: 1,124.02 ns
1,227.11 ns
(92.15%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
22.72 ns
(-14.97%)Baseline: 26.72 ns
31.95 ns
(71.11%)
conversions/Val::from_into📈 view plot
🚷 view threshold
415.39 ns
(+30.38%)Baseline: 318.60 ns
425.88 ns
(97.54%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,892.50 ns
(-1.83%)Baseline: 1,927.79 ns
2,130.69 ns
(88.82%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,256.30 ns
(-15.13%)Baseline: 1,480.28 ns
1,707.14 ns
(73.59%)
function/call Lua📈 view plot
🚷 view threshold
367.96 ns
(+35.92%)Baseline: 270.71 ns
371.43 ns
(99.07%)
function/call Rhai📈 view plot
🚷 view threshold
373.72 ns
(-15.31%)Baseline: 441.30 ns
537.29 ns
(69.56%)
loading/empty Lua📈 view plot
🚷 view threshold
1,090,200.00 ns
(+58.52%)Baseline: 687,730.20 ns
1,854,568.66 ns
(58.78%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,587,000.00 ns
(+67.46%)Baseline: 947,699.00 ns
2,065,603.39 ns
(76.83%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
7,546.50 ns
(-5.56%)Baseline: 7,991.04 ns
9,035.32 ns
(83.52%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,125.20 ns
(-12.30%)Baseline: 6,984.63 ns
8,106.43 ns
(75.56%)
query/10 entities Lua📈 view plot
🚷 view threshold
22,256.00 ns
(+1.81%)Baseline: 21,861.20 ns
24,823.06 ns
(89.66%)
query/10 entities Rhai📈 view plot
🚷 view threshold
18,138.00 ns
(-14.01%)Baseline: 21,092.90 ns
24,190.72 ns
(74.98%)
query/100 entities Lua📈 view plot
🚷 view threshold
45,649.00 ns
(+3.04%)Baseline: 44,303.80 ns
47,752.19 ns
(95.60%)
query/100 entities Rhai📈 view plot
🚷 view threshold
33,572.00 ns
(-4.29%)Baseline: 35,077.70 ns
37,786.13 ns
(88.85%)
query/1000 entities Lua📈 view plot
🚷 view threshold
297,700.00 ns
(+2.29%)Baseline: 291,039.00 ns
321,296.92 ns
(92.66%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
182,590.00 ns
(+3.06%)Baseline: 177,166.00 ns
196,254.37 ns
(93.04%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,648.90 ns
(-10.31%)Baseline: 6,298.59 ns
6,985.25 ns
(80.87%)
reflection/10 Rhai📈 view plot
🚷 view threshold
14,360.00 ns
(-9.49%)Baseline: 15,865.60 ns
17,341.42 ns
(82.81%)
reflection/100 Lua📈 view plot
🚷 view threshold
46,029.00 ns
(-13.29%)Baseline: 53,086.30 ns
60,137.44 ns
(76.54%)
reflection/100 Rhai📈 view plot
🚷 view threshold
801,170.00 ns
(+0.50%)Baseline: 797,213.00 ns
819,199.71 ns
(97.80%)
resource/access Lua📈 view plot
🚷 view threshold
3,764.30 ns
(+0.13%)Baseline: 3,759.54 ns
4,169.91 ns
(90.27%)
resource/access Rhai📈 view plot
🚷 view threshold
4,113.00 ns
(-23.09%)Baseline: 5,347.62 ns
6,547.36 ns
(62.82%)
resource/get Lua📈 view plot
🚷 view threshold
2,184.10 ns
(+0.87%)Baseline: 2,165.25 ns
2,457.48 ns
(88.88%)
resource/get Rhai📈 view plot
🚷 view threshold
2,962.10 ns
(-24.32%)Baseline: 3,913.88 ns
4,861.95 ns
(60.92%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll disabled auto-merge October 25, 2025 12:49
@makspll makspll closed this Oct 25, 2025
@makspll makspll reopened this Oct 25, 2025
@makspll makspll enabled auto-merge (squash) October 25, 2025 13:52
@makspll makspll merged commit be48926 into main Oct 25, 2025
21 checks passed
@makspll makspll deleted the feat/add-script-asset-path-to-function-call-ctxt branch October 25, 2025 14:07
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add call site info to FunctionCallContext

1 participant