Fix: remove stray f in ValueError messages#980
Merged
jonbrenas merged 6 commits intomalariagen:masterfrom Mar 1, 2026
Merged
Conversation
Remove spurious literal 'f' character before the interpolated variable in two ValueError messages, so users see the valid options clearly. Signed-off-by: suhr25 <suhridmarwah07@gmail.com>
Signed-off-by: suhr25 <suhridmarwah07@gmail.com>
Contributor
Author
|
@jonbrenas, |
jonbrenas
approved these changes
Mar 1, 2026
Contributor
Author
|
@jonbrenas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a small formatting issue in error messages where a stray
fwas being shown to users. The issue affects validation insnp_data.pyandhap_data.py, making the output look slightly broken.FIX / CHANGES
Root cause
f{...}inside an f-string) caused a literalfto appear in the final message.Approach
fso the string renders correctly.Before
f"Invalid site mask, must be one of f{self.site_mask_ids}."After
f"Invalid site mask, must be one of {self.site_mask_ids}."VERIFICATION
Steps
Call:
Observe the error message.
Expected result
f.