Skip to content

client/daemon: always delegate RouteAdd regardless of noUninstall flag #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snormore merged 1 commit into from
Jan 13, 2026
Merged

client/daemon: always delegate RouteAdd regardless of noUninstall flag #2606

snormore merged 1 commit into from
Jan 13, 2026
+11 −7

Conversation

@snormore
Copy link
Contributor

@snormore snormore commented Jan 13, 2026

Summary of Changes

  • Always delegate RouteAdd regardless of noUninstall flag in client daemon routeReaderWriterWithNoUninstall
  • This is a bug that affects IBRL-with-allocated-ip users who do not have route liveness passive or active mode enabled, and causes BGP-learned routes not to be installed

Testing Verification

  • Updated test coverage to check for the expectation

@snormore snormore force-pushed the snor/client-fix-install-bug branch from 00cb133 to 8ca4a61 Compare January 13, 2026 01:04
@snormore snormore requested a review from packethog January 13, 2026 01:04
@snormore snormore enabled auto-merge (squash) January 13, 2026 01:34
@snormore snormore merged commit cde1105 into main Jan 13, 2026
21 checks passed
@snormore snormore deleted the snor/client-fix-install-bug branch January 13, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@packethog packethog packethog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snormore @packethog