bugfix(smartcontract): device interface create, update validation #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgm-malbeclabs
force-pushed
the
bgm/ip-net-fix
branch
from
5aefc71 to
f3e4ee5
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements validation rules for device interfaces, ensuring CYOA can only be set on physical interfaces and enforcing consistent validation logic between create and update operations. The changes remove the requirement to tag interfaces and add comprehensive test coverage.
Changes:
- Added validation to restrict
interface-cyoato physical interfaces only - Applied the same validation logic to both create and update interface operations
- Added comprehensive e2e and unit tests for interface validation scenarios
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| smartcontract/programs/doublezero-serviceability/src/state/interface.rs | Added CYOA validation logic restricting it to physical interfaces, updated public IP validation for loopback interfaces with user_tunnel_endpoint, and added unit tests |
| smartcontract/programs/doublezero-serviceability/src/processors/device/interface/update.rs | Added validation call to update operation to ensure consistent validation with create operation |
| smartcontract/programs/doublezero-serviceability/src/error.rs | Added new error variant InvalidCyoaOnLoopback for CYOA validation failures |
| smartcontract/cli/src/device/interface/update.rs | Simplified loopback type validation logic in CLI update command |
| e2e/interface_validation_test.go | Added comprehensive e2e tests validating CYOA restrictions and public IP handling across interface lifecycle |
| e2e/activator_interface_delete_test.go | Updated test to use loopback-type instead of interface-cyoa for loopback interface |
| CHANGELOG.md | Documented interface validation changes and new e2e tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Test 4: Public IP on loopback without user_tunnel_endpoint should be rejected | ||
| if !t.Run("public_ip_on_loopback_without_ute_rejected", func(t *testing.T) { | ||
| testInterfaceName := "Loopback103" | ||
| publicIP := "203.0.113.20/32" // TEST-NET-3 public IP |
There was a problem hiding this comment.
Same as previous comment - clarify that 203.0.113.0/24 is the TEST-NET-3 block per RFC 5737.
bgm-malbeclabs
force-pushed
the
bgm/ip-net-fix
branch
2 times, most recently
from
52b3350 to
fcc9c27
Compare
…e tests for device interface lifecyle (#2664)
bgm-malbeclabs
force-pushed
the
bgm/ip-net-fix
branch
from
fcc9c27 to
f80ad36
Compare
snormore
reviewed
Jan 23, 2026
Co-authored-by: Steven Normore <snormore@gmail.com>
snormore
approved these changes
Jan 23, 2026
Co-authored-by: Steven Normore <snormore@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
From @ben-malbeclabs 's feedback, this PR removes the requirement to tag an interface, only allows
interface-cyoaon a physical interface, and uses the same validation logic on update as for create.Closes #2664
Testing Verification