e2e: fix flaky funder test balance race #2883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move beforeFunderBalance capture to before draining device accounts. The funder service (3s interval) could detect drained accounts and re-fund them before the test captured the baseline, causing the subsequent 2*topUpSOL decrease assertion to never be satisfied.
bgm-malbeclabs
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
beforeFunderBalancecapture to before draining device accounts, fixing a race condition where the funder service (3s interval) could detect drained accounts and re-fund them before the test captured the baseline balance, causing the2*topUpSOLdecrease assertion to never be satisfiedTesting Verification
TestE2E_Funderfailed with "Condition never satisfied" at line 153 after 200s