smartcontract: fix multicast group closeaccount error and add test #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant publisher/subscriber count check from closeaccount (already enforced by DeleteMulticastGroup) and use DoubleZeroError::InvalidStatus instead of raw ProgramError::Custom(1) for the status check. Add test verifying deactivation fails with InvalidStatus when group is not in Deleting status.
elitegreg
approved these changes
Feb 10, 2026
The Rust enum skips discriminant 2 (removed Suspended variant), but the Go, Python, and TypeScript SDKs used sequential values 0-7. Fix all three SDKs and the shared enum_strings.json fixture to use the correct values: 0,1,3,4,5,6,7,8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
process_closeaccount_multicastgroupto useDoubleZeroError::InvalidStatusinstead of rawProgramError::Custom(1)for the status checkDeleteMulticastGroupbefore the group reachesDeletingstatustest_multicastgroup_deactivate_fails_when_not_deletingto verify deactivation is rejected withInvalidStatuswhen the group hasn't been deleted firstTesting Verification
Custom(7)(InvalidStatus) when status isActivatedinstead ofDeleting