Rolling back the desired status process until the health oracle is operational#2929
Merged
juan-malbeclabs merged 8 commits intomainfrom Feb 17, 2026
Merged
Rolling back the desired status process until the health oracle is operational#2929juan-malbeclabs merged 8 commits intomainfrom
juan-malbeclabs merged 8 commits intomainfrom
Conversation
juan-malbeclabs
force-pushed
the
jo/fix-link-update-2
branch
2 times, most recently
from
0a39903 to
7be1086
Compare
juan-malbeclabs
force-pushed
the
jo/fix-link-update-2
branch
from
d3c104a to
0974ae3
Compare
nikw9944
approved these changes
Feb 17, 2026
nikw9944
pushed a commit
that referenced
this pull request
Feb 17, 2026
…erational (#2929) This pull request makes several changes to the CLI and smart contract logic to hide certain fields from the CLI interface and temporarily disable status transition logic for devices and links. The most significant updates are the hiding of the `desired_status` argument in CLI commands and the addition of placeholder logic in status transition methods, pending further implementation. ### CLI Interface Changes * The `desired_status` argument is now hidden in the `CreateDeviceCliCommand`, `UpdateDeviceCliCommand`, and `UpdateLinkCliCommand` structs, making it unavailable to users from the CLI until further notice. [[1]](diffhunk://#diff-28204afbc0daa4568757cbf5a6f1073eabc5092155099845b859903fce876ac0L53-R53) [[2]](diffhunk://#diff-5887bb80e16a3f2882fd495476d15b6ce2324edea81569dc1d169f76921e5531L58-R58) [[3]](diffhunk://#diff-d54a23f19fc3bd80a6e150e51854b5b7c259f844899a3b829676e4e89f714befL53-R53) ### Smart Contract Logic Changes * The `check_status_transition` methods for both `Device` and `Link` structs have been updated to immediately return, effectively disabling their logic for now. This is marked as a temporary measure while waiting for health oracle implementation. [[1]](diffhunk://#diff-d04d83cb0106274b6f52a9dcf75ee6704a3ae64e93a215ffae64eacbf117a860R342-R347) [[2]](diffhunk://#diff-255c929d6c1f6d060a7c2a3dad9fb6f2911da3f5923ac99297d9e163a67eb619R484-R489) * The restriction that only foundation allowlist members can update link status directly has been removed from the `process_update_link` function, allowing any payer to update the status. ## Testing Verification * Show evidence of testing the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several changes to the CLI and smart contract logic to hide certain fields from the CLI interface and temporarily disable status transition logic for devices and links. The most significant updates are the hiding of the
desired_statusargument in CLI commands and the addition of placeholder logic in status transition methods, pending further implementation.CLI Interface Changes
desired_statusargument is now hidden in theCreateDeviceCliCommand,UpdateDeviceCliCommand, andUpdateLinkCliCommandstructs, making it unavailable to users from the CLI until further notice. [1] [2] [3]Smart Contract Logic Changes
check_status_transitionmethods for bothDeviceandLinkstructs have been updated to immediately return, effectively disabling their logic for now. This is marked as a temporary measure while waiting for health oracle implementation. [1] [2]process_update_linkfunction, allowing any payer to update the status.Testing Verification