e2e: fix flaky DeviceTelemetry metrics timeout#2998
Merged
Conversation
WaitForReady passes the outer context (with no deadline) to Fetch, which uses http.DefaultClient (no timeout). When the metrics port silently drops packets (e.g. listener in ns-management before cEOS finishes namespace setup), each HTTP attempt blocks for ~20-30s on TCP connect timeout, starving the poller of retries within the 60s window. Add a 5s per-request timeout so attempts fail fast and the poller can retry properly.
packethog
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricsClient.WaitForReady, fixing a flakyTestE2E_DeviceTelemetryfailure whereny5MetricsClient.WaitForReadytimes out after 60sns-management(vianetns.RunInNamespace). Before cEOS finishes moving eth0 into the management namespace, packets to the metrics port are silently dropped. Without a per-request timeout,http.DefaultClientblocks for ~20-30s per attempt on TCP SYN timeout, allowing only 2-3 retries within the 60s window. With the 5s cap, the poller gets ~12 attempts instead.Testing Verification