bugfix(serviceability): require ip-net for CYOA interfaces#3033
Merged
bgm-malbeclabs merged 1 commit intomainfrom Feb 24, 2026
Merged
bugfix(serviceability): require ip-net for CYOA interfaces#3033bgm-malbeclabs merged 1 commit intomainfrom
bgm-malbeclabs merged 1 commit intomainfrom
Conversation
bgm-malbeclabs
changed the title
bgm-malbeclabs
force-pushed
the
bgm/enforce_cyoa_ip-net
branch
from
285a719 to
8ffc9d1
Compare
bgm-malbeclabs
requested review from
ben-malbeclabs,
Copilot,
elitegreg and
nikw9944
and removed request for
Copilot and
elitegreg
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where CYOA (Choose Your Own Adventure) interfaces could be created without an ip_net, which would default to 0.0.0.0. The fix adds validation in the interface creation processor to require that CYOA interfaces must have an ip_net specified.
Changes:
- Added validation to require ip_net for CYOA interfaces during creation
- Added validation to restrict CYOA to physical interfaces only
- Updated E2E tests to include ip-net flag when creating CYOA interfaces
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| smartcontract/programs/doublezero-serviceability/src/processors/device/interface/create.rs | Added two new validation checks: CYOA can only be set on physical interfaces, and CYOA interfaces must have an ip_net |
| e2e/link_onchain_allocation_test.go | Updated CYOA interface creation commands to include --ip-net flag |
| e2e/interface_validation_test.go | Updated existing test to include --ip-net flag when creating CYOA interface |
| CHANGELOG.md | Added entry documenting the requirement for ip-net on CYOA interfaces |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
smartcontract/programs/doublezero-serviceability/src/processors/device/interface/create.rs
Show resolved
Hide resolved
smartcontract/programs/doublezero-serviceability/src/processors/device/interface/create.rs
Show resolved
Hide resolved
bgm-malbeclabs
force-pushed
the
bgm/enforce_cyoa_ip-net
branch
from
2ef5801 to
5e0b722
Compare
bgm-malbeclabs
changed the title
bgm-malbeclabs
force-pushed
the
bgm/enforce_cyoa_ip-net
branch
from
b2320a4 to
2535303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds the requirement to have an ip_net when a CYOA interface is created. Previously one could create a CYOA interface without an ip_net which would default to
0.0.0.0which doesn't seem like desired behavior.Closes #3032
Testing Verification
ip-netflag for CYOA interfaces