serviceability/client: allow 198.18.0.0/15 IP space#3082
Merged
Conversation
Remove the 198.18.0.0/15 (benchmarking, RFC 2544) range from BGP martian validation in the onchain program, client CLI, and controller so that addresses in this space are accepted.
packethog
approved these changes
Feb 23, 2026
nikw9944
pushed a commit
that referenced
this pull request
Feb 23, 2026
## Summary of Changes - Remove `198.18.0.0/15` (benchmarking, RFC 2544) from BGP martian rejection lists across all three validation points: onchain program, client CLI, and controller - Addresses in the 198.18.0.0/15 range are now accepted as valid IPs ## Diff Breakdown | Category | Files | Lines (+/-) | Net | |--------------|-------|-------------|------| | Core logic | 3 | +3 / -8 | -5 | | Tests | 2 | +4 / -8 | -4 | Straightforward removal of a single martian range check across three components. <details> <summary>Key files (click to expand)</summary> - `smartcontract/programs/doublezero-serviceability/src/helper.rs` — removed 198.18.0.0/15 rejection from `is_global()`, updated test assertions - `client/doublezero/src/command/helpers.rs` — removed 198.18.0.0/15 rejection from `is_bgp_martian()`, updated test assertions - `controlplane/controller/internal/controller/models.go` — added comment noting 198.18.0.0/15 is intentionally excluded from `bgpMartianNets` </details> ## Testing Verification - Onchain `test_is_global` — passes, 198.18.x and 198.19.x now accepted - Client `test_is_bgp_martian` — passes, 198.18.x and 198.19.x now non-martian - Controller `TestIsBgpMartian` — passes (range was already absent from Go list)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
198.18.0.0/15(benchmarking, RFC 2544) from BGP martian rejection lists across all three validation points: onchain program, client CLI, and controllerDiff Breakdown
Straightforward removal of a single martian range check across three components.
Key files (click to expand)
smartcontract/programs/doublezero-serviceability/src/helper.rs— removed 198.18.0.0/15 rejection fromis_global(), updated test assertionsclient/doublezero/src/command/helpers.rs— removed 198.18.0.0/15 rejection fromis_bgp_martian(), updated test assertionscontrolplane/controller/internal/controller/models.go— added comment noting 198.18.0.0/15 is intentionally excluded frombgpMartianNetsTesting Verification
test_is_global— passes, 198.18.x and 198.19.x now acceptedtest_is_bgp_martian— passes, 198.18.x and 198.19.x now non-martianTestIsBgpMartian— passes (range was already absent from Go list)