Skip to content

client: fix OnClose route deletion to scope by peer and skip NoInstall#3123

Merged
packethog merged 1 commit intohotfix/client/v0.8.11from
ss/client_hotfix
Feb 27, 2026
Merged

client: fix OnClose route deletion to scope by peer and skip NoInstall#3123
packethog merged 1 commit intohotfix/client/v0.8.11from
ss/client_hotfix

Conversation

@packethog
Copy link
Contributor

@packethog packethog commented Feb 27, 2026

Summary

  • Cherry-pick of client: fix OnClose route deletion to scope by peer and skip NoInstall #3116 onto the hotfix/client/v0.8.11 branch (without CHANGELOG.md to avoid merge conflict)
  • Fix BGP OnClose deleting routes from all peers instead of only the closing peer — a multicast peer teardown was wiping unicast routes and breaking connectivity
  • Scope route deletion to only routes whose gateway matches the closing peer's address
  • Skip route deletion entirely for NoInstall peers (multicast) since they never install kernel routes

Testing Verification

  • Existing OnClose test updated to include routes from two different peers, verifying only the closing peer's routes are deleted
  • New TestClient_BGPPlugin_OnCloseSkipsRouteDeletionWhenNoInstall verifies that NoInstall peers do not query or delete routes

Cherry-pick of e0e418d (#3116) without CHANGELOG.md to avoid
merge conflict on hotfix branch.
@packethog packethog self-assigned this Feb 27, 2026
@packethog packethog marked this pull request as ready for review February 27, 2026 16:01
@packethog packethog merged commit 542f71e into hotfix/client/v0.8.11 Feb 27, 2026
30 of 31 checks passed
@packethog packethog deleted the ss/client_hotfix branch February 27, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants