e2e: add settling checks between liveness cases to fix intermittent flake#3270
Merged
juan-malbeclabs merged 2 commits intomainfrom Mar 16, 2026
Merged
e2e: add settling checks between liveness cases to fix intermittent flake#3270juan-malbeclabs merged 2 commits intomainfrom
juan-malbeclabs merged 2 commits intomainfrom
Conversation
…lake After unblocking a client, wait for all expected-stable routes to converge before starting the next block/unblock cycle. Without this, Case C's c1->c3 restoration could race against BGP propagation from the prior cycle and fail the 60s timeout.
847a8ca to
daabfda
Compare
snormore
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
client2, the test explicitly verifiesc1->c3andc3->c1are stable before Case C begins blockingclient3c1->c3 restoredassertion to race against the 60s timeoutDiff Breakdown
Single-file change — pure test stabilization, no production code touched.
Key files (click to expand)
e2e/multi_client_ibrl_liveness_test.go— addsrequireEventuallyRoutesettling checks forc1->c3andc3->c1after Case B's unblock, and adds a comment explaining whyc1->c4is intentionally omitted (client4 has liveness disabled and never responds to probes)Testing Verification
TestE2E_MultiClientIBRL_RouteLivenesswith-count=3to exercise three consecutive passes; all passed cleanly (~366–407s per run)c1->c4 restoredcheck (the naive approach) fails consistently, validating the understanding that client4's liveness-disabled config prevents route restoration via probe responses