serviceability: add owner field to UpdateMulticastGroup instruction#3527
Merged
juan-malbeclabs merged 2 commits intomainfrom Apr 13, 2026
Merged
serviceability: add owner field to UpdateMulticastGroup instruction#3527juan-malbeclabs merged 2 commits intomainfrom
juan-malbeclabs merged 2 commits intomainfrom
Conversation
snormore
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
ownerfield toMulticastGroupUpdateArgs, allowing foundation members to reassign ownership of a multicast group after creation--ownerCLI flag todoublezero multicast group update, accepting a pubkey orme(resolves to the active keypair)use_onchain_allocationin the Borsh encoding, so older serialized instructions continue to deserialize correctly viaBorshDeserializeIncrementalDiff Breakdown
Small core change, most of the diff is new and refactored unit tests.
Key files (click to expand)
smartcontract/cli/src/multicastgroup/update.rs— adds--ownerarg withvalidate_pubkey(acceptsme), resolvesmeto the payer pubkey inexecute; adds three new unit tests covering no owner, explicit pubkey, andmeresolutionsmartcontract/programs/doublezero-serviceability/src/processors/multicastgroup/update.rs— addsowner: Option<Pubkey>toMulticastGroupUpdateArgsand applies the update in the processorsmartcontract/sdk/rs/src/commands/multicastgroup/update.rs— addsowner: Option<Pubkey>toUpdateMulticastGroupCommandand threads it through to the instruction argsTesting Verification
test_multicastgroup,test_multicastgroup_deactivate_*,test_delete_multicastgroup_*,test_update_multicastgroup_*)test_multicastgroupextended to setowner: Some(new_owner)in the update step and assert the new owner is persisted on-chaintest_cli_multicastgroup_update_with_explicit_owner,test_cli_multicastgroup_update_owner_me, andtest_cli_multicastgroup_update_owner_parsing