qa: poll USDC balance for finalization in multicast settlement test#3543
Merged
qa: poll USDC balance for finalization in multicast settlement test#3543
Conversation
karl-dz
approved these changes
Apr 16, 2026
Contributor
karl-dz
left a comment
There was a problem hiding this comment.
We should investigate this closer once we get QA working
3bbe7ad to
532fd2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
require.Eventuallyinvalidate_balance_after_payandvalidate_balance_after_withdrawinstead of a single read, with a 30s timeout and 5s interval.FeedSeatPay/FeedSeatWithdraw(which return after tx confirmation) andGetUSDCBalanceatCommitmentFinalized— mainnet finalization lags confirmation by ~13s, so a one-shot finalized read can still see the pre-debit balance.Testing Verification
go build -tags=qa ./e2e/...andgo vet -tags=qa ./e2e/...pass.balanceBeforePay=1008431000,balanceAfterPay=1008431000, debit=0, polled one ~115ms afterFeedSeatPayreturned. With polling, the assertion has up to 30s for the finalized slot to advance past the pay tx.