e2e/qa: wait for multicast status specifically in settlement test#3547
Merged
e2e/qa: wait for multicast status specifically in settlement test#3547
Conversation
snormore
approved these changes
Apr 17, 2026
- add WaitForUnicastStatusUp and WaitForMulticastStatusUp helpers that poll until a status entry of the requested user type exists and is up - switch validate_tunnel_up in TestQA_MulticastSettlement to WaitForMulticastStatusUp so it no longer completes prematurely when a pre-existing IBRL tunnel is already up
packethog
force-pushed
the
ss/elegant-hopper-d8b493
branch
from
44a7d47 to
0f894a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestQA_MulticastSettlement/validate_device_assignmentfailing with "no multicast status found after seat payment" (run 24580260777). On QA hosts with a pre-existing IBRL tunnel, the previousWaitForStatusUpreturned in ~137ms because it only checks that every currently-listed status is up — it has no notion of which tunnel. The Multicast service hadn't been provisioned yet (Solana finalize + activator + 10s reconciler tick + BGP establish), so the subsequentFindMulticastStatusassertion saw only the IBRL entry and failed.WaitForUnicastStatusUpandWaitForMulticastStatusUphelpers that poll for a specific user-type entry to exist and have its session up.validate_tunnel_upin the settlement test toWaitForMulticastStatusUp. Other 13WaitForStatusUpcallers are intentionally left untouched — they'll be audited in a follow-up.Testing Verification
FeedSeatPayreturning and the daemon'sStatus()including a Multicast entry.userType=IBRL currentDevice=dz100a-lax1-tsw doubleZeroIP=206.189.166.187, matching the "up" IP the old helper logged — confirming the Multicast entry was absent, not just not-up.