Conversation
Change `client_filter: Option<String>` to `client_filters: Vec<String>` with `--client-filter` accepting multiple values. A validator matches if its software client contains any of the given names (OR semantics, case-insensitive), matching the admin CLI's `--client` behavior.
ac4714a to
4b22957
Compare
packethog
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
--client-filterflag repeatable, so multiple validator client names can be matched in a single runcontrolplane/doublezero-admin): a validator matches if its software client substring-contains any of the given filter names (case-insensitive OR)client_filter: Option<String>→client_filters: Vec<String>; flag name--client-filteris unchanged, so existing single-value invocations continue to workDiff Breakdown
Small change — the bulk of additions is a new test covering the multi-filter OR semantics.
Key files (click to expand)
crates/sentinel/src/multicast_publisher.rs— filter predicate now OR-matches againstVec<String>; constructor signatures updated; newmultiple_client_filters_match_anytestcrates/sentinel/src/settings.rs—--client-filterdeclared asVec<String>(repeatable)crates/sentinel/src/main.rs— wiring update for the renamed fieldTesting Verification
multiple_client_filters_match_anytest that verifies OR semantics and case-insensitive matching across multiple filter valuesclient_filter_only_creates_for_matching_validatorsstill passes, confirming backward compatibility of the--client-filter fooform