activator: delete activator/ crate from workspace#3647
Open
activator: delete activator/ crate from workspace#3647
Conversation
Phase 3.1 of the activator removal effort (tracker #3607). Onchain allocation (RFC-11) supersedes the offchain activator. Phase 1 (#3608, #3628) froze deployments; Phase 2 (#3611, #3629) removed the activator container from e2e. With nothing depending on the crate building, this PR deletes the source. The User/Device/Link/MulticastGroup activate/reject/closeaccount onchain instructions and their SDK command modules under smartcontract/sdk/rs/src/commands/ are intentionally retained until the min-version gate (Phase 7). - Drop "activator" from the root Cargo.toml workspace members - Delete the activator/ directory (25 files, ~8.6k LoC) - Strip doublezero-activator build/start/kill commands from smartcontract/test/{start-test,start-test-permissions,stop-test}.sh - Refresh Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"activator"from the rootCargo.tomlworkspace members and delete the entireactivator/directory (25 files, ~8.6k LoC)doublezero-activatorbuild/start/kill commands fromsmartcontract/test/{start-test,start-test-permissions,stop-test}.shso the local-validator scripts run without the activatorCargo.lockPhase context
Phase 3.1 of the activator removal effort — tracker #3607, implements #3612.
Onchain allocation (RFC-11) supersedes the offchain activator. Gate is met: Phase 1 froze the deployment and the release pipeline (#3608, #3628); Phase 2 migrated e2e to onchain-only and removed the activator container (#3611, #3629). Nothing in the workspace depends on
activator/building anymore.Intentionally retained
The User/Device/Link/MulticastGroup
activate,reject, andcloseaccountonchain instructions and their SDK command modules undersmartcontract/sdk/rs/src/commands/.../{activate,reject,closeaccount}.rsstay in place — older deployed CLIs still call them. They are removed in Phase 7 oncemin_compatible_versionis bumped.The
--activator-authorityCLI flag also stays (used in the test scripts to set the global config); it is deprecated and removed in Phase 4.Testing Verification
cargo build --workspace— succeeds;Cargo.lockregenerated cleanly with nodoublezero-activatorentrymake rust-build,make rust-lint,make rust-test— all passgrep -r doublezero-activator . --exclude=CHANGELOG.md --exclude-dir=rfcs --exclude-dir=target --exclude-dir=.gitreturns nothing (acceptance criterion)