docs: scrub activator references (phase 6.1)#3734
Merged
Merged
Conversation
Phase 6 of the activator removal effort. Rewrite or remove in-repo docs and inline comments that still refer to the activator as a running component. Code identifiers that reference removed-but-still-in-program fields (activator_authority_pk, ACTIVATOR permission flag, --activator-authority CLI flag) are intentionally preserved and will be cleaned up in a later code-rename PR. - CLAUDE.md: drop the `activator/` architecture row; rewrite the onchain state lifecycle line to "Created in Activated; admin/operator instructions drive subsequent transitions". - DEVELOPMENT.md: drop "activator" from the e2e stack and local devnet component lists. - smartcontract/README.md: remove the Activator section and its node in the contributor-automation flowchart; renumber the remaining components. Simplify the Device, Link, and User mermaid state diagrams to reflect onchain allocation (no Pending/Rejected/Updating/Deleting), and rewrite the lifecycle prose to match. - smartcontract/sdk/rs/README.md: drop "by activator" from a BGP community description. - Rewrite `// activator-only` annotations on `*Deprecated` enum variants to `// deprecated` across Rust state (serviceability program), Go SDK state, and Python SDK state. Numeric discriminants unchanged. - Rewrite stale activator-attributed comments and one user-visible string in the sentinel crate, controlplane/doublezero-admin, client/doublezero, tenant delete CLI/SDK paths, processors/user activate, multicastgroup subscribe, and e2e fork-accounts. - Remove the dead `/activator/ @elitegreg` entry from CODEOWNERS (the crate was deleted in Phase 3) and the dead activator-tag handling in scripts/env.sh and .claude/commands/changelog.md. Part of #3607. Closes #3621.
vihu
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 6.1 of the activator removal effort (tracker #3607, issue #3621). Pure docs/comments scrub — no behavior change.
[*] → Activated, noPending/Rejected/Updating/Deleting).// activator-onlycomments on*Deprecatedenum variants rewritten to// deprecatedacross the Rust program, Go SDK, and Python SDK state files. Numeric discriminants and field names unchanged.crates/sentinel/,controlplane/doublezero-admin/,client/doublezero/,smartcontract/cli/src/tenant/delete.rs(+ SDK variant),processors/user/activate.rs,processors/multicastgroup/subscribe.rs, ande2e/docker/ledger/fork-accounts/src/main.rs./activator/CODEOWNERS line (crate deleted in Phase 3), the activator-tag handling inscripts/env.sh, and theActivatorcomponent name in.claude/commands/changelog.md.Scope — what is intentionally NOT changed
Code identifiers that still exist as public API surface are preserved and will be cleaned up in a later code-rename PR (likely riding alongside the Phase 7 instruction removal):
activator_authority_pkGlobalState field (and SDK mirrors)Activatorvariant inPermissionName/ACTIVATORconstant inpermission_flags--activator-authorityCLI flaggs_with_activator,test_legacy_activator_*)is_activatorlocal binding and// Authorization: allow activator_authority_pk OR foundation_allowlistcomments inauthorize.rs/ processors — these describe the still-present legacy authorization pathThe issue's strict acceptance grep (
grep -ri activator . | grep -v -E '(CHANGELOG|rfcs|target|node_modules)'returns nothing) is therefore not satisfied by this PR — see the residual matches in code identifiers above. PERMISSION.md likewise keeps its "Legacy path" table referencing theACTIVATORflag andactivator_authority_pkfield as factually-accurate code documentation.Testing Verification
make rust-fmt,make rust-lint,make go-lintclean.cargo testondoublezero-serviceability(257 passed),doublezero-sentinel(61 passed),doublezero(127 passed),doublezero_sdk(171 passed),doublezero-admin(8 passed).go test ./smartcontract/sdk/go/... ./sdk/...all packages pass.Part of #3607.
Closes #3621.