geolocation-cli: route prompts through writer, add TTY guard, rename update-payment#3822
Merged
Conversation
…uard, rename update-payment Replace eprint! with write!(out, ...) in init.rs, user/delete.rs, and probe/delete.rs to comply with RFC-20 rule 7. Add IsTerminal check so non-interactive contexts error with a message to pass --yes. Rename UserCommands::UpdatePayment to UpdatePaymentStatus for consistency with the file and SDK naming. Refs: malbeclabs/infra#1461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
init.rs,user/delete.rs, andprobe/delete.rsthrough the injectedWriteparameter instead ofeprint!, complying with RFC-20 rule 7std::io::IsTerminalTTY guard so non-interactive contexts (CI, scripts) get a clear error directing them to pass--yesinstead of hanging on stdinUserCommands::UpdatePaymenttoUpdatePaymentStatusso the CLI subcommand (user update-payment-status) matches the file and SDK namingTesting Verification
doublezero-geolocation-clipass, including 3 new tests verifying non-TTY rejection for each destructive verb (init,user delete,probe delete)cargo clippy -p doublezero-geolocation-cli -- -Dclippy::all -Dwarningspasses with no warningsmake rust-fmtapplied with no formatting changes required