feat: runtime representation of instructions#84
Merged
malcolmstill merged 36 commits intomasterfrom Feb 27, 2021
Merged
Conversation
- Rather than just constantly reprocess the binary representation, provide a structure (actually a union) that we can parse the binary representation into once at module load. This will boost performance
…nstructionIterator (definition)
…le_indices - br_table is the one instruction of variable length
- I had left in a few instructions breaking the code
… instead of []const u8
- That code parameter was used to calculate the continuations which is now down at decode time
- next returns RuntimeInstruction instead of ParseMeta
- we need this for generating a particular testsuite error (wrong number of br_table entries given, which actually ends up consuming some end 0x0b...it's not easy to differentiate this so let's just always check we can find the end of a function)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Speed up execution by moving a bunch of work that is repeatedly performed during execution to the module loading stage
Description
Results
ReleaseSafeexecution time forfib(39)is reduced from around 80 s to around 30 s (putting us roughly on par with python)