fix: pass type_params to _eval_type on Python 3.13 to suppress DeprecationWarning#130
Merged
maldoinc merged 1 commit intomaldoinc:masterfrom Apr 10, 2026
Merged
Conversation
Owner
|
Looks good. Thank you @mvanhorn! |
Contributor
Author
|
Thanks @maldoinc! Appreciate the quick review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_eval_type_nativeinwireup/ioc/util.pyalready passestype_params=()on Python 3.14+, but theDeprecationWarningfires starting in 3.13. This lowers the version check from(3, 14)to(3, 13)so the parameter is passed on 3.13 too.One-line change:
util.pyline 131.Why
The
type_paramsparameter was added totyping._eval_typein Python 3.12. Starting in 3.13, omitting it emits aDeprecationWarning(will become an error in 3.15). The existing fix for 3.14 should also cover 3.13.Fixes #124
This contribution was developed with AI assistance (Claude Code).