Update publisher filter syntax in notebook docs#309
Merged
mtoy-googly-moogly merged 2 commits intoMay 7, 2026
Conversation
Publisher's filter annotation syntax changed from JSON-style
(`#(filter) {"type": "Star"}` on dimensions plus a `##(filters)`
notebook annotation) to source-level declarations with name=/dimension=/type=
parameters. Notebooks now inherit filters automatically from imported
sources—no notebook-level configuration needed.
Updates notebooks.malloynb to match the spec at
malloydata/publisher/docs/filters.md, including the new filter types
(equal/in/like/greater_than/less_than), the implicit/required flags,
and the multiple-filters-per-dimension pattern for date ranges.
I, James Swirhun <james@credibledata.com>, hereby add my Signed-off-by to this commit: ccff94b Signed-off-by: James Swirhun <james@credibledata.com>
quirkyllama
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#(filter) {\"type\": \"Star\"}on dimensions + a##(filters)notebook annotation) to source-level declarations withname=/dimension=/type=parameters. Notebooks now inherit filters automatically from imported sources — no notebook-level config needed.src/documentation/user_guides/notebooks.malloynbto match the spec at malloydata/publisher/docs/filters.md.equal,in,like,greater_than,less_than. Adds theimplicit/requiredflags and the multi-filter-per-dimension pattern (used for date ranges).Carrier Analysisexample link (that source hasn't been migrated to the new syntax); keeps theAuto Recallslink, which has.Test plan
{"type": "Star"}/##(filters)syntax