[codex] Implement local Iceberg accepted sink MVP#162
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dc6d6a7a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9dc6d6a to
da0d83b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #70
What Was Implemented
This PR implements the local filesystem MVP for the Iceberg accepted sink in Floe.
Core changes:
sink.accepted.format: icebergsupport to the accepted sink adapter registry and config validation.floe-corethat writes a valid Iceberg table layout under the configured local table root (metadata/,data/).sink.write_modeflow and accepted sink adapter architecture.write_mode,files_written,table_root_uri,snapshot_idwhen available) while keeping existing report fields backward-compatible.Behavior notes:
appendloads/registers the existing local Iceberg table metadata and commits a new snapshot.overwriterecreates table metadata at the same table root and writes new logical contents (no cleanup/GC of old files/metadata).Supported Scope / Explicit Non-Goals (Issue #70)
Supported in this PR:
icebergwrite_mode:append,overwriteExplicit non-goals in this PR:
Test Coverage Summary
Added / updated tests:
run()integration test that writes an Iceberg table on a temp dir and validates table layout + report fields.Validation run in this branch:
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test --allFollow-up Notes (#71 / #69 / #157)