Skip to content

feat: Support multi-select for combining tab groups#39

Merged
malston merged 1 commit intomalston:mainfrom
AmberAlston:feature/multi-group-select
Nov 30, 2025
Merged

feat: Support multi-select for combining tab groups#39
malston merged 1 commit intomalston:mainfrom
AmberAlston:feature/multi-group-select

Conversation

@AmberAlston
Copy link
Collaborator

@AmberAlston AmberAlston commented Nov 30, 2025

Summary

Enhances the "Combine Groups" feature to support selecting multiple source groups to merge into a single target group.

  • Enable multi-select on source group dropdown (Cmd/Ctrl+click for multiple selections)
  • Update label to indicate multi-select capability
  • All selected source groups merge into target in a single operation
  • Target dropdown automatically excludes all selected source groups
  • Success message shows count of merged groups

Changes

Modified Files

  • src/popup/popup.html - Added multiple attribute to source select, updated label text
  • src/popup/popup.js - Handle array of selected source IDs, updated target filtering logic
  • src/background/combineGroups.js - Accept array of source group IDs, collect tabs from all sources
  • src/background/background.js - Pass sourceGroupIds array to combineGroups
  • src/background/combineGroups.test.js - Added tests for multiple source groups
  • src/popup/popup.test.js - Updated mocks for multi-select behavior

Test Plan

  • Create 3+ tab groups manually in Chrome
  • Click extension → "Combine Groups"
  • Cmd/Ctrl+click to select multiple source groups
  • Verify target dropdown excludes all selected sources
  • Click "Combine" and verify all source groups merge into target
  • Verify success message shows correct count: "Merged 3 group(s) (15 tabs) into..."
  • Verify all source groups are dissolved
  • Test single-select still works (backward compatible)

Screenshots

Screenshot 2025-11-29 at 8 04 37 PM Screenshot 2025-11-29 at 8 04 50 PM Screenshot 2025-11-29 at 8 05 27 PM

@AmberAlston AmberAlston deleted the feature/multi-group-select branch November 30, 2025 03:12
@AmberAlston AmberAlston restored the feature/multi-group-select branch November 30, 2025 03:13
@AmberAlston AmberAlston reopened this Nov 30, 2025
@malston malston merged commit 1499034 into malston:main Nov 30, 2025
10 checks passed
@AmberAlston AmberAlston deleted the feature/multi-group-select branch November 30, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants