Fix linking when using external libraries. #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makefile rules -- when BUILD_* is unset -- did not link the executables against the external libraries they need. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
|
One could make this more fine-grained and link the executables only against the respective libraries they need, but this would have been a much bigger change to the main makefile. Let me know if that would be preferred. |
|
What error are you getting? The introduction of BASELIBS was not to use LIBS. Also there was a change earlier, that added some of the external libraries to BASELIBS. |
The makefile rules -- when BUILD_* is unset -- did not link the executables against the external libraries they need. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Fixes build on NetBSD. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
|
Really lots of missing symbols in the linking steps, e.g. for deflate, crc32, flac*, ... |
|
What tools? Did you pull the latest git since the missing libz and libFLAC symbols have been fixed. |
This reverts commit 8a49e05.
Fixes build on NetBSD. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
|
This was already fixed by the previous pull request 122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The makefile rules -- when BUILD_* is unset -- did not link the
executables against the external libraries they need.
Signed-off-by: Thomas Klausner wiz@NetBSD.org