Adding machine IBM System/23 Datamaster (system23.cpp, non-working); its keyboard; corrections to Intel 8275 #13356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First extensions to the comments
This reverts commit b2daf97.
…ed light pen test to system23.cpp; added methods to check retraces and pixel data; system23 now halts at test 08;
…ors except 34 and 35
angelosa
reviewed
Feb 11, 2025
|
Just wanted to mention in this thread that I did a rewrite of the keyboard to make it look more like the pcxt83 keyboard. They have many similarities. https://github.com/goldnchild/mame/tree/rewrite_sys23_keyboard |
|
Hello, Do not accept this pull up yet. I have found a difference of behaviour between the stock 8275 and the CRTC the Datamaster uses. Since I modified the i8275 to accomodate changes to make the Datamaster work, I have to roll them back and correct them to add this new variant of the component. Sorry for the hassle |
|
Well, you just put the PR in draft if you don't want it to be merged just yet. Also it doesn't compile anyway. |
… standard 8275 and the IBM CRTC;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good afternoon,
I have written the System/23 Datamaster driver. It is non working because there are unimplemented parts of the computer (DMA banking, character ROM banking, etc.) and also has some bugs (randomly crashing at test 19 or giving sporadical ROM errors for uninstalled memories). Other than that, the emulated machine works enough to have BASIC running correctly.
To make it work, some corrections were made to the Intel 8275 (8275.h, 8275.cpp) in order to emulate both its behaviour and also to simulate the light pen, which this computer uses to test the component.
If there is any issue with this driver, please let me know.
Thank you for your attention