seta/jclub2.cpp, seta/st0020.cpp: Cleanups and updates #14291
Merged
+561
−466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seta/st0020.cpp: Split ST0032 as separated device, Cleanups: - Use logmacro.h for logging - Fix spacings - Make some variables constant - Suppress side effects for debugger reads - Use util::sext for sign extend seta/jclub2.cpp: Cleanups: - Reduce duplicates - Reduce runtime tag lookups - Use logmacro.h for logging - Fix save state support - Fix initializer - Fix key matrix reading - Fix spacings - Fix namings - Make some variables constant - Use BIT macro for single bit values - Fix filename in comments - Move driver_init function into machine_start
* sprite_t constructor is redundant with in-place initialisation. * Don't initialise members at declaration when constructor isn't inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seta/st0020.cpp: Split ST0032 as separated device, Cleanups:
seta/jclub2.cpp: Cleanups: