Multiple synth layouts: slider scripts use adjuster's min and max instead of assuming the range is 0-100. #14320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... min and max instead of assuming the range is 0-100. * Script in `linn_linndrum.lay` updated to take advantage of mamedev#14317. * The linndrum script was copied to `esq1.lay`, `oberheim_dmx.lay`, `paia_fatman.lay`, `roland_d70.lay`, `roland_tr707.lay`. * Script in `pg1000.lay` updated to take advantage of mamedev#14317. * Nroadened the `inputmask` for sliders and knobs in all layouts. Related minor fixes: * esq1.cpp: Fixed adjuster defaults to be within range. * roland_tr707.lay: Corrected volume slider click area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linn_linndrum.layupdated to take advantage of luaengine_input.cpp: Export minvalue and maxvalue for IPT_ADJUSTER. #14317.esq1.lay,oberheim_dmx.lay,paia_fatman.lay,roland_d70.layandroland_tr707.lay. Note that the diffs for some of these look large. That's because they were using older versions of the "reference" script inlinn_linndrum.lay.pg1000.layupdated accordingly. This had local changes, so didn't just copy the reference.inputmaskfor sliders and knobs in all layouts, so they can accommodate ranges beyond 0-127.Related minor fixes:
esq1.cpp: Fixed adjuster defaults to be within range. Defaults were being set to 255, but the adjuster's range was 100, and the driver and layout assumed that too.roland_tr707.lay: Corrected volume slider click area. Also fixes the knob sliding below the cursor when dragged.