toaplan/slapfght.cpp: Split driver classes to different hardware configuration, Minor cleanups #14351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration, Minor cleanups - Reduce literal tag usages and runtime tag lookups - Remove unnecessary variable - Reduce duplicates - Fix filename in comments - Make some variables constant - Suppress side effects for debugger reads
cuavas
reviewed
Oct 17, 2025
src/mame/toaplan/slapfght_m.cpp
Outdated
Comment on lines
41
to
52
| { | ||
| static const int states[3]={ 0xc7, 0x55, 0x00 }; | ||
| static const uint8_t states[3]={ 0xc7, 0x55, 0x00 }; | ||
|
|
||
| m_getstar_status = states[m_getstar_status_state]; | ||
| if (!machine().side_effects_disabled()) | ||
| { | ||
| m_getstar_status = states[m_getstar_status_state]; | ||
|
|
||
| m_getstar_status_state++; | ||
| if (m_getstar_status_state > 2) m_getstar_status_state = 0; | ||
| m_getstar_status_state++; | ||
| if (m_getstar_status_state > 2) m_getstar_status_state = 0; | ||
| } | ||
|
|
||
| return m_getstar_status; |
There was a problem hiding this comment.
This won’t show the actual value that would be returned in the debugger with this change. You need to do something like:
static const uint8_t states[3] = { 0xc7, 0x55, 0x00 };
const uint8_t result = states[m_getstar_status_state];
if (!machine().side_effects_disabled())
{
m_getstar_status = result;
m_getstar_status_state++;
if (m_getstar_status_state > 2) m_getstar_status_state = 0;
}
return result;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.