VET 3000, "The Video Effects Titler" #14364
Merged
+628
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MooglyGuy
reviewed
Oct 19, 2025
src/mame/tms/vet3000.cpp
Outdated
| INPUT_PORTS_END | ||
|
|
||
|
|
||
| #define MAIN_CLOCK 3.579545_MHz_XTAL |
There was a problem hiding this comment.
Would you be alright with making this a static member of the class instead of using a #define? I'm not super bothered about it either way, but it caught my eye by looking a bit out-of-place here.
by Tecnologia em Micro Sistemas (Brazilian company), 1988 https://datassette.org/node/106385 https://www.youtube.com/watch?v=DJXlqe2UXKs
felipesanches
force-pushed
the
vet3000
branch
from
0e88e48 to
dc6d138
Compare
galibert
reviewed
Oct 22, 2025
src/mame/tms/vet3000.cpp
Outdated
| { | ||
| for (u8 i=0; i<7; i++) | ||
| if (!BIT(m_scan, i)) | ||
| return m_row[i]->read(); |
There was a problem hiding this comment.
Isn't that an and of all the outputs for which a m_scan bit is zero?
There was a problem hiding this comment.
Yes, I think that's more accurate, indeed. I've just fixed it. Thanks!
galibert
reviewed
Oct 22, 2025
src/mame/tms/vet3000.cpp
Outdated
| }; | ||
|
|
||
|
|
||
| void vet3000_state::keyboard_w(u8 data){ |
There was a problem hiding this comment.
Also fixed the formatting now.
|
Thanks! |
cuavas
reviewed
Oct 30, 2025
Comment on lines
+100
to
+107
| PORT_BIT(0x01, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_1) | ||
| PORT_BIT(0x02, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_Q) | ||
| PORT_BIT(0x04, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_A) | ||
| PORT_BIT(0x08, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_LSHIFT) PORT_CODE(KEYCODE_RSHIFT) | ||
| PORT_BIT(0x10, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_7) | ||
| PORT_BIT(0x20, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_U) | ||
| PORT_BIT(0x40, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_J) | ||
| PORT_BIT(0x80, IP_ACTIVE_LOW, IPT_OTHER) PORT_CODE(KEYCODE_N) |
There was a problem hiding this comment.
You should really be using IPT_KEYBOARD and PORT_NAME or PORT_CHAR for all the keys. It’s not going to be a good experience like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by Tecnologia em Micro Sistemas (Brazilian company), 1988