Follow-up to PR#14263 -- move implementation details out of headers etc. #14384
+171
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure, src/devices/bus/rc2014/sound.cpp does not see device_rc2014_card_interface. Which means you either didn't even try to compile or changed something just before pushing. Bad idea either way. |
galibert
reviewed
Oct 22, 2025
cuavas
reviewed
Oct 29, 2025
| //************************************************************************** | ||
| // TYPE DEFINITIONS | ||
| //************************************************************************** | ||
| DECLARE_DEVICE_TYPE(BK_LOOPBACK, device_qbus_card_interface) |
There was a problem hiding this comment.
Ah, this doesn’t even match the definition – it’s declared as exposing device_qbus_card_interface here, but actual public interface is device_bk_parallel_interface. Does this work at all?
There was a problem hiding this comment.
It only “worked” by chance. I can’t believe I have to add a pile of code to explicitly guard against doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.