Fix led 30 layout issues. #14494
Draft
Fix led 30 layout issues. #14494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the led still blinking when error happens.
ajrhacker
requested changes
Nov 8, 2025
I forgot to add. to prevent error during compiler.
Contributor
|
The point still stands. To be specific, |
Updated output finder 48 to 40 and uint8_t i = 0; i < 8; i++) to (uint8_t i = 0; i < 0; i++)
ajrhacker
reviewed
Nov 8, 2025
src/mame/misc/marywu.cpp
Outdated
| void marywu_state::p3_port_w(uint8_t data) // 1 led are used. | ||
| { | ||
| for (uint8_t i = 0; i < 8; i++) | ||
| for (uint8_t i = 0; i < 0; i++) |
Contributor
There was a problem hiding this comment.
This causes the loop to be executed zero times, defeating the whole purpose of adding this as a callback.
Since external memory is hooked up to the MOVX space, it's unlikely P36 and P37 are used to drive LEDs, but some of the lower 6 bits might be.
flama12333
changed the title
…3_port_w function
Contributor
Author
|
Currently in draft. |
Sorry for causing the confusion.
flama12333
changed the title
flama12333
changed the title
Change output_finder<40> m_leds; to output_finder<31> m_digits; change for (uint8_t i = 0; i < 8; i++) to for (uint8_t i = 0; i < 7; i++)
flama12333
changed the title
Contributor
Author
|
I had to remove p3_port_w due to an mistake without checking something. |
flama12333
added a commit
to flama12333/mame
that referenced
this pull request
Nov 16, 2025
Rename inputs p1 0x80 clear credits? added p1 port description. fix typo. Currently not tested due to preliminary emulation. expected to have issues. led 30 still set off. should blink if error happen. see also mamedev#14494
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change uint8_t to 7 at ay2_port_b_w.
and output_finder m_leds to 31.