Add pypi python 3.13 build to the pipeline #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
force-pushed
the
feature/add_py313
branch
from
b1dd059 to
7b6fc86
Compare
phoebusm
force-pushed
the
feature/add_py313
branch
from
5ad1153 to
9a0e71f
Compare
phoebusm
changed the title
phoebusm
requested review from
alexowens90,
poodlewars and
willdealtry
as code owners
phoebusm
force-pushed
the
feature/add_py313
branch
3 times, most recently
from
05817ca to
c0d5784
Compare
phoebusm
force-pushed
the
feature/add_py313
branch
from
c0d5784 to
4e9bbec
Compare
G-D-Petrov
reviewed
Jan 15, 2025
Collaborator
G-D-Petrov
left a comment
G-D-Petrov
left a comment
There was a problem hiding this comment.
LGTM but can you also run the persistent storage tests just in case
| if: matrix.os == 'linux' | ||
| run: echo /opt/python/${{env.python_impl_name}}*/bin >> $GITHUB_PATH | ||
| run: | | ||
| #there are cp313 and cp313t |
Collaborator
There was a problem hiding this comment.
what us the difference between the two?
Collaborator
Author
There was a problem hiding this comment.
cp313 with t is the experimental free threading version
poodlewars
reviewed
Jan 15, 2025
Collaborator
poodlewars
left a comment
poodlewars
left a comment
There was a problem hiding this comment.
Is our pybind version new enough for Python 3.13?
Collaborator
Author
@poodlewars |
G-D-Petrov
approved these changes
Jan 16, 2025
Collaborator
G-D-Petrov
left a comment
G-D-Petrov
left a comment
There was a problem hiding this comment.
The persistent tests passed correctly here so I am approving.
poodlewars
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Depends on #2050. Need to rebase after #2050 is merged
What does this implement or fix?
Add python3.13 build to pipeline and upgrade grpc for 3.13 wheel build
Any other comments?
Checklist
Checklist for code changes...